Skip to content

fix: increase contrast for replay buttons#4912

Merged
juergba merged 2 commits intomochajs:masterfrom
JoshuaKGoldberg:replay-button-accessibility
Sep 20, 2022
Merged

fix: increase contrast for replay buttons#4912
juergba merged 2 commits intomochajs:masterfrom
JoshuaKGoldberg:replay-button-accessibility

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 17, 2022 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Adds the increased visual emphasis as mentioned in #4911.

Light mode Dark mode
Light mode screenshot with more visible replay buttons Dark mode screenshot with more visible replay buttons

Alternate Designs

n/a

Why should this be in core?

n/a

Benefits

Users can more easily see the replay buttons.

Possible Drawbacks

n/a

Applicable issues

@juergba
Copy link
Copy Markdown
Contributor

juergba commented Aug 18, 2022

@JoshuaKGoldberg thank you.
IMO the result looks worse than before with the arrows being white now.

@JoshuaKGoldberg
Copy link
Copy Markdown
Member Author

JoshuaKGoldberg commented Aug 18, 2022

Shoot, sorry @juergba - I switched them from black to #fff last minute, forgetting that it's #000 for black 🤦. Updated now.

@juergba
Copy link
Copy Markdown
Contributor

juergba commented Aug 28, 2022

@JoshuaKGoldberg the support for dark color scheme has been added recently. Please rebase and solve the conflicts, thanks.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the replay-button-accessibility branch from 6783850 to d3ccdfb Compare September 4, 2022 00:01
juergba
juergba reviewed Sep 13, 2022
View reviewed changes
Comment thread mocha.css Outdated
@juergba juergba added area: browser browser-specific area: usability concerning user experience or interface semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Sep 13, 2022
@juergba juergba added this to the next milestone Sep 13, 2022
juergba
juergba approved these changes Sep 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaKGoldberg thank you for this PR.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 20, 2022

Coverage Status

Coverage remained the same at 94.326% when pulling 0518abb on JoshuaKGoldberg:replay-button-accessibility into 41567df on mochajs:master.

@juergba juergba added the run-browser-test run browser tests on forked PR if code is safe label Sep 20, 2022
@github-actions github-actions Bot removed the run-browser-test run browser tests on forked PR if code is safe label Sep 20, 2022
@juergba juergba merged commit 4e06a6f into mochajs:master Sep 20, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg restored the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg deleted the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg restored the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg deleted the replay-button-accessibility branch September 20, 2022 16:22
@juergba juergba added area: reporters involving a specific reporter and removed area: usability concerning user experience or interface labels Sep 20, 2022
@Grizzelbee Grizzelbee mentioned this pull request Jul 18, 2024
Closed
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
@JoshuaKGoldberg
fix(browser): increase contrast for replay buttons (mochajs#4912)
929bad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@juergba juergba juergba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: browser browser-specific area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes"

Projects

None yet

Milestone

v10.1.0

Development

Successfully merging this pull request may close these issues.

Inaccessible filter/replay buttons in browser reporter

3 participants

@JoshuaKGoldberg @juergba @coveralls