Skip to content

Fix typo in licenses#571

Merged
djs55 merged 1 commit intomoby:masterfrom
mat007:update-licenses
Apr 5, 2022
Merged

Fix typo in licenses#571
djs55 merged 1 commit intomoby:masterfrom
mat007:update-licenses

Conversation

@mat007
Copy link
Copy Markdown
Contributor

@mat007 mat007 commented Apr 5, 2022 •
edited
Loading

This silently adds fd-send-recv.2.0.1 with an empty type.

Fix typo in licenses
ce5ee02 
This silently makes fd-send-recv.2.0.1 have an empty type.

Signed-off-by: Docker Desktop <desktop-exp-team+merge-queue@docker.com>
@mat007
Copy link
Copy Markdown
Contributor Author

mat007 commented Apr 5, 2022

Or maybe it’s due to something else, it didn’t seem to have made a difference…

@mat007
Copy link
Copy Markdown
Contributor Author

mat007 commented Apr 5, 2022

I’m not sure why else, these now look similar

  | "fd-send-recv.2.0.1" -> {
    link = "https://github.com/xapi-project/ocaml-fd-send-recv/blob/7c9b151a7cc54f11c45280177027d9d42473737c/LICENSE";
    text = lgpl21_with_ocaml_linking_exception;
  }

and

  | "ocplib-endian.1.2" -> {
    link = "https://github.com/OCamlPro/ocplib-endian/blob/10292cd3ffa4d23d737e3f855ad04f22d3d95460/COPYING.txt";
    text = lgpl21_with_ocaml_linking_exception;
  }

but the latter has a correct type inferred…

djs55
djs55 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit rusty, but I thought the trailing ; was optional. However it makes for cleaner diff so I'm all for it!

@djs55 djs55 merged commit e82cae2 into moby:master Apr 5, 2022
@mat007
Copy link
Copy Markdown
Contributor Author

mat007 commented Apr 5, 2022

Oh I think it is optional. I can’t understand why computing the type works for some and not exactly identical others…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djs55 djs55 djs55 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mat007 @djs55