Merged
Conversation
Signed-off-by: Mathieu Champlon <mathieu.champlon@docker.com>
Merged
thaJeztah
reviewed
Mar 9, 2022
| github.com/labstack/echo v3.3.10+incompatible | ||
| github.com/linuxkit/virtsock v0.0.0-20180830132707-8e79449dea07 | ||
| github.com/pkg/errors v0.8.1-0.20181023235946-059132a15dd0 | ||
| github.com/sirupsen/logrus v1.3.0 |
Member
There was a problem hiding this comment.
we should update this to a more current version; IIRC, this old version is known to not be compatible with go1.13 and up
thaJeztah
reviewed
Mar 9, 2022
| github.com/google/uuid v0.0.0-20170814143639-7e072fc3a7be | ||
| github.com/labstack/echo v3.3.10+incompatible | ||
| github.com/linuxkit/virtsock v0.0.0-20180830132707-8e79449dea07 | ||
| github.com/pkg/errors v0.8.1-0.20181023235946-059132a15dd0 |
Member
There was a problem hiding this comment.
This version is not compatible with go1.13 error wrapping; we should update that as well
thaJeztah
reviewed
Mar 9, 2022
|
|
||
| require ( | ||
| github.com/Microsoft/go-winio v0.4.11 | ||
| github.com/google/uuid v0.0.0-20170814143639-7e072fc3a7be |
Member
There was a problem hiding this comment.
this one has tagged releases, and (I may be mistaken ) but there may be security issues with older version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
1.16to1.17then did ago mod tidy.