[28.x backport] vendor: update buildkit to v0.23.1#50243
Merged
[28.x backport] vendor: update buildkit to v0.23.1#50243
Conversation
crazy-max
approved these changes
Jun 20, 2025
thaJeztah
reviewed
Jun 20, 2025
| github.com/mistifyio/go-zfs/v3 v3.0.1 | ||
| github.com/mitchellh/copystructure v1.2.0 | ||
| github.com/moby/buildkit v0.23.0-rc2 | ||
| github.com/moby/buildkit v0.23.1 |
Member
There was a problem hiding this comment.
This also includes #50222 ? Did we skip that commit?
Contributor
Author
There was a problem hiding this comment.
We didn't backport the previous PR, but I don't think it's needed now?
Member
There was a problem hiding this comment.
Yeah, mostly that we normally use the "cherry-pick -x" so that we have a clear reference to where it was backported from, so in this case, I'd have expected both commits to be found, leading to the original commits/PRs
Contributor
Author
There was a problem hiding this comment.
Not sure if there's a real value in recording the intermediate commit, but updated the PR to also include it.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com> (cherry picked from commit e43968d) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com> (cherry picked from commit 5a02e7f) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
approved these changes
Jun 20, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
if CI was green before this, we can probably merge without waiting for it to finish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)