dockerd-rootless-setuptool.sh: Fix silent stop on error due to using output redirection together wit…#50059
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 3, 2025
Merged
Conversation
AkihiroSuda
reviewed
May 24, 2025
Member
|
The issue seems a regression in v28.0 |
Member
|
Thanks for updating; could you squash the commits? |
Contributor
Author
done. |
Contributor
Author
|
actually, seems like this might need a rebase to the diverged new upstream master first. I'll have to do this tomorrow.. |
AkihiroSuda
reviewed
May 28, 2025
…h `set -eu`. Signed-off-by: Shang Mu <smu@princeton.edu>
AkihiroSuda
approved these changes
May 28, 2025
Member
|
@thaJeztah @vvoland Can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dockerd-rootless-setuptool.sh: Fix silent stop on error when subuid/subgid system requirements are not satisfied.
- What I did
- How I did it
- How to verify it
Use an account without relevant entries in /etc/subuid or /etc/subgid and run
dockerd-rootless-setuptool.sh checkordockerd-rootless-setuptool.sh install. It should print '[ERROR] ...' instead of silently returns.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)