containerd: ensure overwritten images from load are left dangling#49650
Merged
vvoland merged 1 commit intomoby:masterfrom Apr 4, 2025
Merged
containerd: ensure overwritten images from load are left dangling#49650vvoland merged 1 commit intomoby:masterfrom
vvoland merged 1 commit intomoby:masterfrom
Conversation
vvoland
requested changes
Mar 18, 2025
Contributor
vvoland
left a comment
There was a problem hiding this comment.
Thanks, that's clever solution!
Could we also have some test for this?
1360f0f to
00718a9
Compare
Collaborator
Author
|
Integrated the feedback and added an integration test. |
00718a9 to
f6fd153
Compare
Collaborator
Author
vvoland
reviewed
Mar 24, 2025
f6fd153 to
c2af120
Compare
During a load, ensure any existing images are left as dangling images. This affects the `docker load` command with the containerd snapshotter backend. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
c2af120 to
8f506a5
Compare
vvoland
approved these changes
Mar 27, 2025
dmcgowan
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a load, ensure any existing images are left as dangling images.
This affects the
docker loadcommand with the containerd snapshotterbackend.
Fixes the
loadportion of #48907.