[27.x backport] otel: Avoid excessive memory allocations if not configured#49079
Merged
[27.x backport] otel: Avoid excessive memory allocations if not configured#49079
Conversation
Use noop tracer provider if the OTEL exporter is not configured. This makes the OTEL tracing avoid doing unneeded memory allocations for spans which aren't going to be exported anywhere anyway. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 4847557) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 899360b) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Needed for Buildkit history Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit d8358eb) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport: otel: Avoid excessive memory allocations if not configured #49078
fixes: Memory leak #49075
relates to Make log reading more robust to errors #47983
Use noop tracer provider if the OTEL exporter is not configured. This makes the OTEL tracing avoid doing unneeded memory allocations for spans which aren't going to be exported anywhere anyway.
- How to verify it
Before this patch, the RSS grows significantly over time, in proportion to the amount of running
docker logs -f.After the patch, the RSS stays around the same level.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)