Skip to content

[24.0 backport] Skip cache lookup for "FROM scratch" in containerd#45822

Merged
thaJeztah merged 1 commit intomoby:24.0from
thaJeztah:24.0_backport_containerd-from-scratch
Jun 27, 2023
Merged

[24.0 backport] Skip cache lookup for "FROM scratch" in containerd#45822
thaJeztah merged 1 commit intomoby:24.0from
thaJeztah:24.0_backport_containerd-from-scratch

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jun 27, 2023

Ideally, this should actually do a lookup across images that have no parent, but I wasn't 100% sure how to accomplish that so I opted for the smaller change of having FROM scratch builds not be cached for now.

(cherry picked from commit 1741771)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Ideally, this should actually do a lookup across images that have no parent, but I wasn't 100% sure how to accomplish that so I opted for the smaller change of having `FROM scratch` builds not be cached for now.

Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
(cherry picked from commit 1741771)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review kind/bugfix PR's that fix bugs containerd-integration Issues and PRs related to containerd integration labels Jun 27, 2023
@thaJeztah thaJeztah added this to the 24.0.3 milestone Jun 27, 2023
@thaJeztah thaJeztah merged commit 4735ce7 into moby:24.0 Jun 27, 2023
@thaJeztah thaJeztah deleted the 24.0_backport_containerd-from-scratch branch June 27, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

containerd-integration Issues and PRs related to containerd integration kind/bugfix PR's that fix bugs status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

4 participants