[24.0 backport] fix docker cp -a failing to access / in container (run getent with a noop stdin)#45748
Merged
neersighted merged 1 commit intomoby:24.0from Jun 14, 2023
Merged
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> (cherry picked from commit 3cc5d62) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cpuguy83
approved these changes
Jun 14, 2023
Member
neersighted
approved these changes
Jun 14, 2023
Member
Author
|
@neersighted was it new though? As this already was there (but we may have changed how we use the code) https://github.com/golang/go/blame/5c5c2c8112f774b118b9251eb15c2df529ad454c/src/pkg/os/exec/exec.go#L145 |
Member
|
Ah, that's a fair point -- I managed to misunderstand some of my own spelunking and was convinced that this was new in https://go-review.googlesource.com/c/go/+/401834. I do wonder where the regression crept in then -- possibly the re-exec elimination work? |
Member
Author
|
Yes, I suspect the latter indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker cp -afailing to access/in container (rungetentwith a noop stdin) #45720(cherry picked from commit 3cc5d62)
- What I did
configure command to run
getentto use a noop readCloser as stdin to prevent ENOENT failure to open/dev/null- How I did it
- How to verify it
test case included
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
