Conversation
- fix docker service create doesn't work when network and generic-resource are both attached - Fix removing tasks when a jobs service is removed - CSI: Allow NodePublishVolume even when plugin does not support staging full diff: moby/swarmkit@904c221...80a528a Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 088aff1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
8162af9 to
3bd2fc8
Compare
Member
Author
|
re-did the cherry-pick as the commit in master changed; minor conflict ( |
Member
Author
|
Hitting this flaky again on Windows 2022; |
cpuguy83
approved these changes
Mar 9, 2023
neersighted
approved these changes
Mar 9, 2023
mmenozzi
added a commit
to webgriffe/swarm-cron
that referenced
this pull request
Mar 21, 2023
Hoping that when the PR moby/moby#45107 will be realeased we don't get infinite orphaned tasks on the swarm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker service rmforreplicated-jobservice leaves orphaned task #44312full diff: moby/swarmkit@904c221...80a528a
(cherry picked from commit 1a1f5b3)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)