fix a possible panic on cache#3670
Merged
jedevc merged 1 commit intomoby:masterfrom Feb 24, 2023
Merged
Conversation
Contributor
Author
|
We encountered 1-5 panics per 30,000 builds, it's related to lzay layer with image ref annotation. |
jedevc
reviewed
Feb 24, 2023
Member
jedevc
left a comment
There was a problem hiding this comment.
Nice catch 🎉
I think we want to make sure that the annotations map doesn't contain an empty map - it should either contain elements, or be nil.
29b1893 to
04dff4b
Compare
Contributor
Author
Thanks for the reply, fixed. |
```
newDesc.Annotations = nil
for _, k := range addAnnotations {
newDesc.Annotations[k] = desc.Annotations[k]
}
```
The codes may cause buildkitd panic: assignment to entry in nil map
Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
04dff4b to
39bd8c6
Compare
jedevc
approved these changes
Feb 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codes may cause buildkitd panic: assignment to entry in nil map