fix: handle multiple handler's envs on same the doc#507
Merged
pawamoy merged 1 commit intomkdocstrings:masterfrom Jan 11, 2023
Merged
fix: handle multiple handler's envs on same the doc#507pawamoy merged 1 commit intomkdocstrings:masterfrom
pawamoy merged 1 commit intomkdocstrings:masterfrom
Conversation
pawamoy
requested changes
Jan 6, 2023
Member
|
And yeah CI breaks from time to time, I'll handle it. |
Member
|
CI is fixed on master, you can rebase on it 🙂 |
Instead of a boolean of has any env been updated, track by handle name which env has been updated. References: mkdocstrings#201 Fixes: 502
4cf5dd0 to
3850d86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't want to take the full performance hit of doing it every time, so it now tracks if this autodoc instance has seen this handler before and if not; updates the handler's env.
Additionally, add a doc string to
_update_envjust a breadcrumb.References: #201
Fixes: #502
I had issues with the instructions in
contributing.mdand had to manually install pdm on both windows/osx. I got format working but check_types and test failed in locations not associated with this change.