IMO the various checks (the new PrivateAttr) are better to be isolated into a separate function since there are quite a few of them now. I didn't want to change this without your approval @pawamoy

Tested on my docs - seems to be working fine

Thanks @danielgafni, looking good. I'm OK with a refactor that splits apart each check into a dedicated function 🙂 Either as a second commit on this PR (but you'll have to follow our commit message guidelines), or as a second PR, thanks for suggesting!

Let's do another PR then.

I fixed the commit title and body.

The CI is failing on something that seems to be unrelated to my changes?

Yeah don't pay attention to CI I'll fix it. Just make sure tests pass locally 🙂

Hey @pawamoy , pinging in case you've forgotten about this PR (also sorry if this is annoying and let me know if I shouldn't be doing it)

to be clear, the tests were passing locally for me

Pings are welcome, thanks for asking 😄 I'll get to it soon 🙂