Skip to content

feat: Better support for dataclasses#240

Merged
pawamoy merged 6 commits intomainfrom
better-dataclasses-support
Mar 5, 2024
Merged

feat: Better support for dataclasses#240
pawamoy merged 6 commits intomainfrom
better-dataclasses-support

Conversation

@pawamoy
Copy link
Copy Markdown
Member

@pawamoy pawamoy commented Feb 29, 2024

Closes #233, #234, #238, #239.

TODO:

  • remove d.py
  • add more tests (coming from mentioned issues)
  • detect when dataclasses extension functionality was used, to issue a deprecation warning? or leave it enabled by default for eternity?

@pawamoy pawamoy force-pushed the better-dataclasses-support branch from 558057c to e44ebf5 Compare February 29, 2024 12:14
@pawamoy pawamoy marked this pull request as ready for review February 29, 2024 13:32
@pawamoy
Copy link
Copy Markdown
Member Author

pawamoy commented Feb 29, 2024

@has2k1 would you like to review? When squashing I'll add you as co-author since your issues were super helpful and I reused your code for tests 🙂

@has2k1
Copy link
Copy Markdown
Contributor

has2k1 commented Feb 29, 2024

Nice, looks good so far. I will have time to test it over the weekend.

@pawamoy pawamoy force-pushed the better-dataclasses-support branch from f51c37b to b78b2f2 Compare March 5, 2024 14:13
@pawamoy pawamoy merged commit 82a9d57 into main Mar 5, 2024
@pawamoy pawamoy deleted the better-dataclasses-support branch November 26, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: A dataclass field with init=False should not be a parameter

2 participants