Skip to content

feat: Add HTML classes to references#16

Merged
pawamoy merged 4 commits intomasterfrom
mark-external-links
Mar 6, 2022
Merged

feat: Add HTML classes to references#16
pawamoy merged 4 commits intomasterfrom
mark-external-links

Conversation

@pawamoy
Copy link
Copy Markdown
Member

@pawamoy pawamoy commented Mar 5, 2022

This allows custom styling through CSS.

@pawamoy pawamoy force-pushed the mark-external-links branch from f1b349b to 04406c3 Compare March 5, 2022 22:57
@pawamoy pawamoy changed the title feat: Add 'external' HTML class to external references feat: Add HTML classes to references Mar 5, 2022
Copy link
Copy Markdown
Member

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, "internal" "external" are possibly too generic, like, what if people already have existing CSS using those classes?

Co-authored-by: Oleh Prypin <oleh@pryp.in>
@pawamoy
Copy link
Copy Markdown
Member Author

pawamoy commented Mar 6, 2022

Yeah I wondered the same thing. Then maybe class="autorefs autorefs-external" or class="autorefs autorefs-internal"?

@oprypin
Copy link
Copy Markdown
Member

oprypin commented Mar 6, 2022

Yes I think that would be better.

@pawamoy pawamoy merged commit 39db59d into master Mar 6, 2022
@pawamoy pawamoy deleted the mark-external-links branch November 26, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants