Conversation
This partly reverts changes in commit e755aae as some of that functionality will be deprecated. Several more edge cases are taken into account now. Co-authored-by: Waylan Limberg <waylan.limberg@icloud.com>
Contributor
Author
|
I have now also implemented extraction of
|
Contributor
Author
|
@waylan , I don't need much of a review here, but I would need to hear from you whether you're OK to include the source code that's derived from your code but under the license of this repository. |
waylan
approved these changes
Mar 8, 2024
Member
waylan
left a comment
There was a problem hiding this comment.
Looks good to me. I approve the use of the borrowed code. 👍
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partly reverts changes in commit e755aae as some of that functionality will be deprecated.
Several more edge cases are taken into account now.
It now more closely follows the approach that Python-Markdown will take soon.
@waylan This contains code copied from your pull request. (The purpose of copying is to not require a new version of Python-Markdown.) Are you OK with this code being put under the license of this repository?