Skip to content

Fix docs for test.runner_fallback config key #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-sixty merged 1 commit into from
Jan 2, 2026
Merged

Fix docs for test.runner_fallback config key #853

max-sixty merged 1 commit into from
Jan 2, 2026

Conversation

@max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Jan 2, 2026 •
edited
Loading

Summary

The documentation showed test_runner_fallback as the config key, but the code expected runner_fallback. This is consistent with other keys under test::

test:
  runner: nextest          # not test_runner
  runner_fallback: true    # not test_runner_fallback (was documented wrong)
  unreferenced: warn       # not test_unreferenced
  auto_review: true        # not test_auto_review

Changes

  • Fix documentation to show correct key: runner_fallback
  • Add integration test verifying config file setting works
  • Fix typo in error message (INSTA_RUNNER_FALLBACK → INSTA_TEST_RUNNER_FALLBACK)

Example

# .config/insta.yaml
test:
  runner: nextest
  runner_fallback: true  # this is the correct key

🤖 Generated with Claude Code

@max-sixty max-sixty changed the title Fix config file test_runner_fallback being ignored Align config key test_runner_fallback with docs, CLI, and env var Jan 2, 2026
@max-sixty @claude
Fix docs for test.runner_fallback config key
6a25309 
The documentation incorrectly showed `test_runner_fallback` as the config
key, but the code expected `runner_fallback` (consistent with `runner`
and other keys under `test:`).

This fixes the documentation and adds a test to verify the config works.

Also fixes a typo in the error message (`INSTA_RUNNER_FALLBACK` →
`INSTA_TEST_RUNNER_FALLBACK`).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@max-sixty max-sixty changed the title Align config key test_runner_fallback with docs, CLI, and env var Fix docs for test.runner_fallback config key Jan 2, 2026
@max-sixty max-sixty merged commit fd40cf7 into mitsuhiko:master Jan 2, 2026
15 checks passed
@max-sixty max-sixty deleted the fallback-bug branch January 2, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@max-sixty