cargo-insta: reduce visibility of all items#407
cargo-insta: reduce visibility of all items#407mitsuhiko merged 2 commits intomitsuhiko:masterfrom tamird:fix-insta-profile
Conversation
marcospb19
left a comment
There was a problem hiding this comment.
👍 I tested and it's working as expected.
|
Not a maintainer — but would it make sense to split off the visibility changes from the more urgent fix? |
|
It does make sense, but I wonder if it matters. It's already separated in commits, so reviewing is easy. |
|
I'm a bit confused here. The flag has been fixed on master already and the pull request contains hundreds of lines of unrelated changes. |
|
@mitsuhiko I must've not pulled before sending this PR. The unrelated changes are explained in the commit message; I'll edit the PR description as these changes are the only changes now. |
|
I'm not sure what the motivation is change the visibility here. |
|
@mitsuhiko the motivation is explained in the commit message (and now in the PR description). Does that help? |
Items which are marked pub are not considered by rustc's dead code lints, allowing obvious bugs like the one fixed in 84cddf9.
Unclear if there's a purpose for this field, but it is never read.
|
Makes sense. Merged. |
Items which are marked pub are not considered by rustc's dead code
lints, allowing obvious bugs like the one fixed in 84cddf9.
This exposed the fact that
PendingSnapshot.idis unused, so#[allow(dead_code)]is added to that field.