cargo-insta: allow passing --profile#402
Merged
mitsuhiko merged 1 commit intomitsuhiko:masterfrom Sep 9, 2023
tamird:add-profile
Merged
cargo-insta: allow passing --profile#402mitsuhiko merged 1 commit intomitsuhiko:masterfrom tamird:add-profile
mitsuhiko merged 1 commit intomitsuhiko:masterfrom
tamird:add-profile
Conversation
mitsuhiko
approved these changes
Sep 9, 2023
Contributor
Author
|
Thanks @mitsuhiko. Could you cut a new cargo-insta release with this fix please? |
marcospb19
reviewed
Sep 16, 2023
| pub release: bool, | ||
| /// Build artifacts with the specified profile | ||
| #[structopt(long)] | ||
| pub profile: String, |
Contributor
There was a problem hiding this comment.
Now profiles are required, the following doesn't work anymore:
cargo insta testYou need this:
cargo insta test --profile dev -- uiWas this intended? If not I can create the fix PR with
-pub profile: String,
+pub profile: Option<String>,
Contributor
Author
There was a problem hiding this comment.
Oh boy, it's worse than that. The logic is looking at features rather than profile. Feel free to send a fix for both issues, else I'll do so tomorrow.
Contributor
There was a problem hiding this comment.
I'll let you go for it because I didn't detect the other issue you just did :V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #381.