fix: remove hard-coded pdoc mention from title in template#841
Merged
mhils merged 2 commits intomitmproxy:mainfrom Oct 18, 2025
Merged
fix: remove hard-coded pdoc mention from title in template#841mhils merged 2 commits intomitmproxy:mainfrom
mhils merged 2 commits intomitmproxy:mainfrom
Conversation
Contributor
Author
|
I forgot to say: I'm not sure how or if at all you want this change to be stated in the changelog. Just let me know and I can add that 👍 |
mhils
approved these changes
Oct 18, 2025
Member
mhils
left a comment
There was a problem hiding this comment.
Thanks! This looks perfect. The other two uses are fine, they are fairly unambiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #839
There are two more occurrences of
pdoc {{ __version__ }}in the jinja2 templates:pdoc/pdoc/templates/default/error.html.jinja2
Line 36 in a12c236
pdoc/pdoc/templates/default/frame.html.jinja2
Line 6 in a12c236