IamAwsProvider: fix custom endpoint having non-default port#1523
Merged
Conversation
Contributor
Author
|
As to the pipeline errors they are most likely unrelated to my changes - same error occurs on master branch and the class i touched is not used during the testes, so it should not affect them. I manually tested the built library in an example app based on the FileUploader from project's README, just to authenticate and call an API method. As far as i recall the tests fail because min.io instance expected to run TLS is not running TLS, hence giving this error. |
balamurugana
requested changes
Jan 17, 2024
… relation to the used protocol
balamurugana
requested changes
Feb 22, 2024
balamurugana
left a comment
Member
There was a problem hiding this comment.
As okhttp3.HttpUrl is taking care of default port for http and https, this commit should be reverted
balamurugana
approved these changes
Feb 22, 2024
minio-trusted
approved these changes
Mar 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1522