Add AMTRELAY and IPSECKEY RR types#1402
Merged
miekg merged 5 commits intomiekg:masterfrom Feb 26, 2023
Merged
Conversation
Owner
|
looks good in general, but I've got a bunch of nits and questions. You can also update the README and add RFC 8777 and 4025 |
miekg
reviewed
Nov 19, 2022
miekg
reviewed
Nov 19, 2022
miekg
reviewed
Nov 19, 2022
miekg
reviewed
Nov 19, 2022
miekg
reviewed
Nov 19, 2022
miekg
reviewed
Nov 19, 2022
miekg
reviewed
Nov 19, 2022
miekg
reviewed
Nov 19, 2022
tmthrgd
requested changes
Jan 6, 2023
Collaborator
tmthrgd
left a comment
There was a problem hiding this comment.
Mostly fine with me, just a handful of nits to address.
Owner
|
@tmthrgd you happy with this now? If so, you (or I) can click 'squash and merge' |
Collaborator
|
@miekg There's still one un-resolved review comment about |
tmthrgd
reviewed
Feb 15, 2023
dcb1d8f to
ce7b45f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the AMTRELAY and IPSECKEY RR types to this library, and bumps dependencies because
go generateappears to be broken otherwise.