chore: use test() helper in type tests#1472
Merged
willfarrell merged 1 commit intomiddyjs:mainfrom Sep 10, 2025
mrazauskas:use-type-test-helpers
Merged
chore: use test() helper in type tests#1472willfarrell merged 1 commit intomiddyjs:mainfrom mrazauskas:use-type-test-helpers
test() helper in type tests#1472willfarrell merged 1 commit intomiddyjs:mainfrom
mrazauskas:use-type-test-helpers
Conversation
Signed-off-by: mrazauskas <tom@mrazauskas.de>
mrazauskas
commented
Sep 10, 2025
Comment on lines
+10
to
+13
| test("use with all options", () => { | ||
| const middleware = httpEventNormalizer(); | ||
| expect(middleware).type.toBe<middy.MiddlewareObj<Event>>(); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
This one looks like a duplicate of the above test. Or I missed something?
jonathanstumm
approved these changes
Sep 10, 2025
willfarrell
approved these changes
Sep 10, 2025
Member
|
Awesome! Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR replaces comments with the
test()helper in type tests. The helpers improve structure of the test files..onlyand.skipcan be used while debugging.The diff is mostly white space change.
Tips. When running a single file, TSTyche will print out the structure with passing / failing test cases:
npx tstyche utils. You can use--onlyand--skipdirectly from CLI:npx tstyche utils --only choose.Note.
packages/core/index.test-d.tswas too complex for me. I left it for follow up PR.Todo List: