Improve feature search UX, add dark mode, and update deps#3422
Merged
Improve feature search UX, add dark mode, and update deps#3422
Conversation
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- web/features/tsconfig.json: Language not supported
Comments suppressed due to low confidence (4)
web/features/src/app.tsx:167
- The initialization of the query state with params.query! ?? '' might cause an error if params.query is undefined. It should be initialized with params.query ?? '' instead.
const [query, setQuery] = useState(params.query! ?? '');
web/features/src/worker/search.ts:100
- [nitpick] The variable name 'query_lower' is ambiguous. It should be renamed to 'queryLower' for better readability.
const query_lower = query.toLowerCase();
web/features/src/worker/search.ts:101
- [nitpick] The variable name 'a_lower' is ambiguous. It should be renamed to 'nameALower' for better readability.
const a_lower = a.name.toLowerCase();
web/features/src/worker/search.ts:102
- [nitpick] The variable name 'b_lower' is ambiguous. It should be renamed to 'nameBLower' for better readability.
const b_lower = b.name.toLowerCase();
kennykerr
approved these changes
Jan 7, 2025
Collaborator
Author
|
@tim-weis Heads up Tim, added a few of the items you requested! (e.g., better result sort) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: