Detect unsupported array parameters#3402
Merged
kennykerr merged 4 commits intomicrosoft:masterfrom Jan 6, 2025
Merged
Conversation
…ng array parameter that is confused for a result value and returned as such.
Contributor
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
Oh, this looks like it impacts parameters that are attributed as array parameters but that are then discarded as invalid by |
kennykerr
reviewed
Jan 6, 2025
Collaborator
|
Builds are failing with latest Rust toolchain following the holidays - I'll work on that separately and then we can update these PRs. |
kennykerr
approved these changes
Jan 6, 2025
kennykerr
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where windows-bindgen confuses an unsupported trailing array parameter for a result value and then generates code that dereferences it and tries to return it.
@kennykerr I believe I have tracked down the source of the reintroduction of the bug that had been reported prior. You mentioned providing a minimal repro in #3384. I added a generated test in the code to ensure that it's working as expected. Please let me know if this is what you expected, and what else, if anything, that I need to do to get this pull request accepted. Thanks!
Fixes #3384