Skip to content

Implement codefix for MSTEST0026: Avoid conditional access in assertions (and small analyzer false positive) #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Evangelink merged 7 commits into from
Jan 7, 2025
Merged

Implement codefix for MSTEST0026: Avoid conditional access in assertions (and small analyzer false positive) #4502

Evangelink merged 7 commits into from
Jan 7, 2025

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 3, 2025 •
edited
Loading

Fixes #4501
Fixes #3661

@Youssef1313 Youssef1313 force-pushed the mstest0026-codefix branch 2 times, most recently from 523b779 to 4cb8280 Compare January 3, 2025 11:18
@Youssef1313 Youssef1313 changed the title Mstest0026 codefix Implement codefix for MSTEST0026: Avoid conditional access in assertions Jan 7, 2025
@Youssef1313 Youssef1313 marked this pull request as ready for review January 7, 2025 07:16
@Youssef1313 Youssef1313 changed the title Implement codefix for MSTEST0026: Avoid conditional access in assertions Implement codefix for MSTEST0026: Avoid conditional access in assertions (and small analyzer false positive) Jan 7, 2025
@Evangelink
Copy link
Member

Evangelink commented Jan 7, 2025

As discussed offline, let's merge and we will do a follow-up if we get feedback from roslyn on improvements or problems related to this custom batcher.

@Evangelink Evangelink merged commit 6dcb80f into microsoft:main Jan 7, 2025
10 checks passed
@Youssef1313 Youssef1313 deleted the mstest0026-codefix branch January 7, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees

No one assigned

Labels

Area: Analyzers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MSTEST0026 (Avoid conditional access in assertions) false positive for conditional access in message/messageArgs Add code fix for MSTEST0026

2 participants

@Youssef1313 @Evangelink