Skip to content

Introduce interpolated string handler overloads for assertions #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Evangelink merged 46 commits into from
Jan 3, 2025
Merged

Introduce interpolated string handler overloads for assertions #4476

Evangelink merged 46 commits into from
Jan 3, 2025

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 30, 2024 •
edited
Loading

Fixes #4273

@Youssef1313 Youssef1313 mentioned this pull request Dec 30, 2024
Closed
@Youssef1313 Youssef1313 marked this pull request as ready for review December 30, 2024 18:02
@Youssef1313 Youssef1313 requested a review from Copilot December 30, 2024 18:03
Evangelink
Evangelink reviewed Dec 31, 2024
View reviewed changes
Evangelink
Evangelink reviewed Dec 31, 2024
View reviewed changes
Evangelink
Evangelink reviewed Dec 31, 2024
View reviewed changes
Evangelink
Evangelink reviewed Dec 31, 2024
View reviewed changes
Evangelink
Evangelink reviewed Dec 31, 2024
View reviewed changes
Evangelink
Evangelink reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please apply the various suggestions on AreEqual globally?

@Youssef1313 Youssef1313 requested a review from Evangelink January 2, 2025 09:10
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jan 2, 2025

Thanks for the review @Evangelink. Those comments were really very helpful and revealed some important issues.

Evangelink
Evangelink approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. I didn't review every single test added but I assume you have used the same pattern everywhere so LGTM

@Evangelink Evangelink merged commit 950c909 into microsoft:main Jan 3, 2025
10 checks passed
@Youssef1313 Youssef1313 deleted the interpolated-string-handler branch January 4, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evangelink Evangelink Evangelink approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

Area: Assertion Area: Performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add interpolated string handler overloads for Assert methods

2 participants

@Youssef1313 @Evangelink