Skip to content

OpenAPIDocumentParser class clean-up.#1390

Merged
lemillermicrosoft merged 1 commit intomicrosoft:mainfrom
SergeyMenshykh:open-api-clean-up
Jun 12, 2023
Merged

OpenAPIDocumentParser class clean-up.#1390
lemillermicrosoft merged 1 commit intomicrosoft:mainfrom
SergeyMenshykh:open-api-clean-up

Conversation

@SergeyMenshykh
Copy link
Member

Description and Motivation

The OpenAPIDocumentParser class has been updated to make it kernel-agnostic and enable easy reuse in other components where the conversion functionality may not be needed or may be different.

Disclaimer: The conversion logic has not been changed, and the purpose of this pull request is solely to relocate the conversion logic from the parser class and not to enhance the logic itself.

Contribution Checklist

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jun 9, 2023
@SergeyMenshykh SergeyMenshykh added .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews and removed .NET Issue or Pull requests regarding .NET code labels Jun 9, 2023
@shawncal shawncal force-pushed the open-api-clean-up branch from 6ecce6a to 783871c Compare June 12, 2023 19:18
@lemillermicrosoft lemillermicrosoft merged commit b703b51 into microsoft:main Jun 12, 2023
@lemillermicrosoft lemillermicrosoft added this to the Sprint 33 milestone Jun 20, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Description and Motivation 
The OpenAPIDocumentParser class has been updated to make it
kernel-agnostic and enable easy reuse in other components where the
conversion functionality may not be needed or may be different.

**Disclaimer**: The conversion logic has not been changed, and the
purpose of this pull request is solely to relocate the conversion logic
from the parser class and not to enhance the logic itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants