Skip to content

SKFunction should return Task<string>#1334

Merged
lemillermicrosoft merged 8 commits intomicrosoft:mainfrom
feiyun0112:issue-1321
Jun 15, 2023
Merged

SKFunction should return Task<string>#1334
lemillermicrosoft merged 8 commits intomicrosoft:mainfrom
feiyun0112:issue-1321

Conversation

@feiyun0112
Copy link
Contributor

@feiyun0112 feiyun0112 commented Jun 4, 2023

#1321

Function 'GetMyDirectReportsEmailAsync' has an invalid signature not supported by the kernel.

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jun 4, 2023
@stephentoub
Copy link
Member

stephentoub commented Jun 4, 2023

It's supported as of #1195. That just needs to be merged. cough @shawncal cough 😄

@stephentoub
Copy link
Member

stephentoub commented Jun 4, 2023

Oh, sorry, I misread the subject. I see now the function currently returns Task<IEnumerable<string>>, which my PR doesn't enable, yet. We'd just need to decide what the semantics should be of that, and then we could enable it.

@lemillermicrosoft lemillermicrosoft added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. labels Jun 15, 2023
@lemillermicrosoft lemillermicrosoft linked an issue Jun 15, 2023 that may be closed by this pull request
Throwing Invalid Signature For Return Type of GetMyDirectReportsEmailAsync() #1321
Closed
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) June 15, 2023 19:05
@lemillermicrosoft lemillermicrosoft merged commit 32a1185 into microsoft:main Jun 15, 2023
@feiyun0112 feiyun0112 deleted the issue-1321 branch June 16, 2023 01:41
@GrahamOlson11 GrahamOlson11 mentioned this pull request Jun 16, 2023
Closed
@lemillermicrosoft lemillermicrosoft added this to the Sprint 33 milestone Jun 20, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@feiyun0112 @lemillermicrosoft
SKFunction should return Task<string> (microsoft#1334)
0debd98 
microsoft#1321 

Function 'GetMyDirectReportsEmailAsync' has an invalid signature not
supported by the kernel.

Co-authored-by: Lee Miller <lemiller@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lemillermicrosoft lemillermicrosoft lemillermicrosoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

Semantic Kernel
Archived in project

Milestone

Sprint 33

Development

Successfully merging this pull request may close these issues.

Throwing Invalid Signature For Return Type of GetMyDirectReportsEmailAsync()

3 participants

@feiyun0112 @stephentoub @lemillermicrosoft