Skip to content

LogInformation placeholder bug fix#1497

Merged
adrianwyatt merged 4 commits intomicrosoft:mainfrom
teresaqhoang:fixing-logger-bug
Jun 15, 2023
Merged

LogInformation placeholder bug fix#1497
adrianwyatt merged 4 commits intomicrosoft:mainfrom
teresaqhoang:fixing-logger-bug

Conversation

@teresaqhoang
Copy link
Contributor

Motivation and Context

LogInformation replaces placeholders positionally, not by index of param array, so need to add a third placeholder param.

Contribution Checklist

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jun 15, 2023
@teresaqhoang teresaqhoang self-assigned this Jun 15, 2023
@teresaqhoang teresaqhoang added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 15, 2023
@adrianwyatt adrianwyatt enabled auto-merge (squash) June 15, 2023 01:43
@adrianwyatt adrianwyatt merged commit 15fc47e into microsoft:main Jun 15, 2023
@teresaqhoang teresaqhoang deleted the fixing-logger-bug branch June 16, 2023 16:50
@teresaqhoang teresaqhoang restored the fixing-logger-bug branch June 16, 2023 16:50
@teresaqhoang teresaqhoang deleted the fixing-logger-bug branch June 16, 2023 16:54
@evchaki evchaki added this to the Sprint 33 milestone Jun 30, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants