Skip to content

Revert "fix(windows): hide console window when spawning browser processes"#39994

Merged
Skn0tt merged 1 commit intomainfrom
revert-38776-main
Apr 1, 2026
Merged

Revert "fix(windows): hide console window when spawning browser processes"#39994
Skn0tt merged 1 commit intomainfrom
revert-38776-main

Conversation

@Skn0tt
Copy link
Copy Markdown
Member

@Skn0tt Skn0tt commented Apr 1, 2026

Reverts #38776, closes #39990

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:118 › screencast › should capture static page `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:118 › screencast › should capture static page `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`

39108 passed, 846 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Test results for "MCP"

2 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest
❌ [msedge] › mcp/files.spec.ts:106 › clicking on download link emits download @mcp-windows-latest

6310 passed, 370 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit 5f2f65a into main Apr 1, 2026
37 of 39 checks passed
@Skn0tt Skn0tt deleted the revert-38776-main branch April 1, 2026 16:09
pavelfeldman pushed a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression]: Codegen and UI mode doesn't open on Windows

2 participants