Skip to content

fix(snapshot): draw a minimum size browser window for small snapshots#37640

Merged
agg23 merged 2 commits intomicrosoft:mainfrom
agg23:snapshot-minimum-browser-size-render
Oct 2, 2025
Merged

fix(snapshot): draw a minimum size browser window for small snapshots#37640
agg23 merged 2 commits intomicrosoft:mainfrom
agg23:snapshot-minimum-browser-size-render

Conversation

@agg23
Copy link
Copy Markdown
Contributor

@agg23 agg23 commented Sep 29, 2025

DOM snapshots can be very small, to the point that our "browser" chrome around the document no longer displays correctly. Set a minimum width and height for our "browser", marking out of bounds areas with a checkerboard pattern.

Screenshot 2025-09-29 at 11 13 56 AM Screenshot 2025-09-29 at 11 14 01 AM Screenshot 2025-09-29 at 11 14 04 AM

@agg23 agg23 requested a review from pavelfeldman September 29, 2025 18:14
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks

@agg23 agg23 merged commit d1fdd81 into microsoft:main Oct 2, 2025
35 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2025

Test results for "tests 1"

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397 › should work behind reverse proxy `@macos-latest-node18-1`

46902 passed, 811 skipped


Merge workflow run.

whazor pushed a commit to whazor/playwright-trace-viewer-plus that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants