Skip to content

cherry-pick(#29706): fit(ct): remove unused type import#29709

Merged
mxschmitt merged 1 commit intorelease-1.42from
cherry-pick-1.42-2024-02-28-12-32-31
Feb 29, 2024
Merged

cherry-pick(#29706): fit(ct): remove unused type import#29709
mxschmitt merged 1 commit intorelease-1.42from
cherry-pick-1.42-2024-02-28-12-32-31

Conversation

@playwrightmachine
Copy link
Contributor

@playwrightmachine playwrightmachine commented Feb 28, 2024

This PR cherry-picks the following commits:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

Test results for "tests 1"

6 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:215:5 › should watch component via util
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

26582 passed, 613 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

Test results for "tests 2"

2 fatal errors, not part of any test
11 failed
❌ [chromium] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium] › page/page-event-request.spec.ts:72:3 › should report requests and responses handled by service worker with routing
❌ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
❌ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
❌ [firefox] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [firefox] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit] › library/capabilities.spec.ts:67:3 › should play video @smoke
❌ [webkit] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [webkit] › library/modernizr.spec.ts:33:3 › safari-14-1
❌ [webkit] › library/modernizr.spec.ts:82:3 › mobile-safari-14-1
❌ [webkit] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

73 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:139:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [chromium] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/trace-viewer.spec.ts:873:1 › should serve overridden request
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/capabilities.spec.ts:260:3 › requestFullscreen
⚠️ [firefox] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › page/page-click.spec.ts:445:3 › should wait for stable position
⚠️ [firefox] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [firefox] › library/hit-target.spec.ts:366:3 › should detect overlayed element in a transformed iframe
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › page/page-goto.spec.ts:112:3 › should work with Cross-Origin-Opener-Policy after redirect
⚠️ [firefox] › page/page-request-continue.spec.ts:290:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
⚠️ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/trace-viewer.spec.ts:96:1 › should open trace viewer on specific host
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked: false }) should have expected: false
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [chromium] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:340:7 › cli codegen › should press
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [webkit] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:291:7 › cli codegen › should fill textarea
⚠️ [webkit] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:196:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:450:7 › cli codegen › should check
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:520:7 › cli codegen › should uncheck
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:584:7 › cli codegen › should select with size attribute
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:625:7 › cli codegen › should await popup
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should assert value
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:634:7 › cli codegen › should assert visibility
⚠️ [webkit] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-viewport-mobile.spec.ts:57:5 › mobile viewport › should be detectable by Modernizr
⚠️ [webkit] › library/browsercontext-viewport-mobile.spec.ts:66:5 › mobile viewport › should detect touch when applying viewport with touches
⚠️ [webkit] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
⚠️ [webkit] › library/trace-viewer.spec.ts:755:1 › should open two trace files
⚠️ [webkit] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [webkit] › library/browsercontext-add-cookies.spec.ts:428:3 › should allow unnamed cookies

180804 passed, 8013 skipped, 1252 did not run
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 20db86d into release-1.42 Feb 29, 2024
@mxschmitt mxschmitt deleted the cherry-pick-1.42-2024-02-28-12-32-31 branch February 29, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@playwrightmachine @mxschmitt