Skip to content

fit(ct): remove unused type import#29706

Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom
beckerei:beckerei-patch-1
Feb 28, 2024
Merged

fit(ct): remove unused type import#29706
mxschmitt merged 1 commit intomicrosoft:mainfrom
beckerei:beckerei-patch-1

Conversation

@beckerei
Copy link
Contributor

@beckerei beckerei commented Feb 28, 2024

I think this was overlooked in #29463 when fixing #29461 as the error still exists in @playwright/experimental-ct-react@1.42.0

I don't understand the test failure, I can't see a relation to the proposed change.

Signed-off-by: Flo Becker <flo@die-beckerei.de>
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [firefox] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts

9 flaky ⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke

26584 passed, 613 skipped
✔️✔️✔️

Merge workflow run.

@beckerei beckerei marked this pull request as ready for review February 28, 2024 11:57
@mxschmitt mxschmitt merged commit 772345c into microsoft:main Feb 28, 2024
mxschmitt pushed a commit that referenced this pull request Feb 29, 2024
This PR cherry-picks the following commits:

- 772345c

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants