fix(chromium): avoid premature continue of redirects#27520
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Oct 10, 2023
Merged
fix(chromium): avoid premature continue of redirects#27520dgozman merged 1 commit intomicrosoft:mainfrom
dgozman merged 1 commit intomicrosoft:mainfrom
Conversation
This has recently regressed in microsoft#27429. We now continue requests that are paused for the second time. However, redirects share `networkId` with the original request, so we may confuse paused redirect with a second pause for the original request. This is covered by the flaky test `page-route.spec.ts:392 > should work with redirects for subresources`
yury-s
approved these changes
Oct 10, 2023
Contributor
Test results for "tests 1"1 failed 6 flaky25848 passed, 603 skipped Merge workflow run. |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
This has recently regressed in microsoft#27429. We now continue requests that are paused for the second time. However, redirects share `networkId` with the original request, so we may confuse paused redirect with a second pause for the original request. This is covered by the flaky test `page-route.spec.ts:392 > should work with redirects for subresources` References microsoft#27294.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has recently regressed in #27429.
We now continue requests that are paused for the second time. However, redirects share
networkIdwith the original request, so we may confuse paused redirect with a second pause for the original request.This is covered by the flaky test
page-route.spec.ts:392 > should work with redirects for subresourcesReferences #27294.