Fixed issue with SQLServerBulkCopy from CSV with setEscapeColumnDelimerts set to true#2575
Fixed issue with SQLServerBulkCopy from CSV with setEscapeColumnDelimerts set to true#2575
Conversation
|
Hi @machavan |
Yes, bulk Copy offers a significant performance advantage. Please refer: and Bulk Copy API for Batch Insert: https://learn.microsoft.com/en-us/sql/connect/jdbc/use-bulk-copy-api-batch-insert-operation?view=sql-server-ver16 |
lilgreenbird
left a comment
There was a problem hiding this comment.
see comment re test cleanup
|
Hi @machavan can you please let us know when this will be available for us to consume also whats the plan will this fix be available with the next version release? if so can you please let us know when is that planned also will it be a minor version upgrade or a major version upgrade? |
|
Hi @machavan can you please provide clarification for the concern I have mentioned in the previous comment or provide any ETA for the same? |
We will look to include this fix in the next release, will update you shortly on the timeline for the same. |
6adfc61
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
============================================
+ Coverage 51.22% 51.24% +0.02%
- Complexity 3953 3968 +15
============================================
Files 147 147
Lines 33657 33657
Branches 5624 5624
============================================
+ Hits 17241 17248 +7
- Misses 13999 14003 +4
+ Partials 2417 2406 -11 ☔ View full report in Codecov by Sentry. |
|
ADO tests passed for this PR. |
|
Hi @machavan |
Hi @yatharthgovil , We are planning for a release around Feb end/March start |
Description:
The method
SQLServerBulkCSVFileRecord::readLineEscapeDelimitersintroduced for supporting newline characters as part of field values ( #2338) missed to handle the case of CSV file not having a newline character at the end of the last row in CSV file, resulting into skipping the last record when setEscapeColumnDelimerts is set to true.Tests: