Fixed getGeneratedKeys functionality for execute API#2554
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
============================================
+ Coverage 51.22% 51.37% +0.14%
- Complexity 3953 3976 +23
============================================
Files 147 147
Lines 33657 33664 +7
Branches 5624 5626 +2
============================================
+ Hits 17241 17295 +54
+ Misses 13999 13936 -63
- Partials 2417 2433 +16 ☔ View full report in Codecov by Sentry. |
Contributor
|
Internal tests pass |
…ev/machavan/issue#2550
|
Suggestion: may also wish to verify that the execute API works with |
Contributor
Author
Yes, verified with execute API and added a new test case |
David-Engel
approved these changes
Jan 23, 2025
divang
approved these changes
Jan 29, 2025
Contributor
Author
|
ADO pipeline tests passed with the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The execute API for INSERT was not reading off the explicit TDS_DONE token that actually contains the update count returned by the server. As a result, it was not able to correctly report back the update count for getUpdateCount and also the subsequent resultsets on getMoreResults.
Note that this works correctly for excecuteUpdate API.
Testing: