Removed exception and validation for user/password with AccessTokenCallback#2549
Removed exception and validation for user/password with AccessTokenCallback#2549Jeffery-Wasty merged 4 commits intomainfrom
Conversation
…WithUserPassword. This logic may be too restrictive and may be removed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2549 +/- ##
============================================
+ Coverage 50.96% 50.99% +0.03%
Complexity 3912 3912
============================================
Files 147 147
Lines 33460 33456 -4
Branches 5608 5604 -4
============================================
+ Hits 17052 17060 +8
+ Misses 13999 13989 -10
+ Partials 2409 2407 -2 ☔ View full report in Codecov by Sentry. |
… case in PooledConnectionTest.java
@microsoft-github-policy-service agree company="Microsoft" |
lilgreenbird
left a comment
There was a problem hiding this comment.
instead of just stating what the code change is, update title to be more descriptive and add in comments if necessary. Also remove reference to "Feature-32573" here that is meaningless
The SQLServerConnection connectInternal() method throws the exception R_AccessTokenCallbackWithUserPassword. This logic may be too restrictive and has therefore been removed.