Skip to content

chore(web-components): remove web types#32308

Merged
radium-v merged 5 commits intomicrosoft:masterfrom
radium-v:users/johnkreitlow/remove-web-types
Aug 15, 2024
Merged

chore(web-components): remove web types#32308
radium-v merged 5 commits intomicrosoft:masterfrom
radium-v:users/johnkreitlow/remove-web-types

Conversation

@radium-v
Copy link
Contributor

@radium-v radium-v commented Aug 14, 2024

Previous Behavior

The @types/web package was incorrectly configured, which caused configuration issues downstream.

New Behavior

The @types/web package is removed, and all missing types in the web-components package are marked with // @ts-expect-error - Baseline 2024 when appropriate.

The api-extractor had issues when ToggleEvent was present but missing, so in those instances the types have been downgraded to Event.

This also updates all playwright tests to use the new toHaveCustomState custom assertion, which avoids calling ElementInternals.states directly.

Related Issue(s)

@radium-v radium-v requested review from a team as code owners August 14, 2024 21:06
@chrisdholt chrisdholt mentioned this pull request Aug 14, 2024
Closed
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Aug 14, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 39 38 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 683 633 5000
Button mount 300 314 5000
Field mount 1152 1160 5000
FluentProvider mount 702 727 5000
FluentProviderWithTheme mount 77 86 10
FluentProviderWithTheme virtual-rerender 39 38 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 82 77 10
MakeStyles mount 877 877 50000
Persona mount 1790 1718 5000
SpinButton mount 1409 1443 5000
SwatchPicker mount 1630 1652 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 93 78 1.19:1
ChatDuplicateMessagesPerf.default 167 148 1.13:1
TreeWith60ListItems.default 102 91 1.12:1
ButtonSlotsPerf.default 335 301 1.11:1
AnimationMinimalPerf.default 322 295 1.09:1
ImageMinimalPerf.default 230 214 1.07:1
LabelMinimalPerf.default 235 219 1.07:1
ButtonMinimalPerf.default 92 87 1.06:1
FormMinimalPerf.default 243 229 1.06:1
ListWith60ListItems.default 388 366 1.06:1
RefMinimalPerf.default 115 109 1.06:1
TextAreaMinimalPerf.default 297 280 1.06:1
AvatarMinimalPerf.default 116 110 1.05:1
CardMinimalPerf.default 323 307 1.05:1
RadioGroupMinimalPerf.default 266 254 1.05:1
AlertMinimalPerf.default 171 164 1.04:1
ChatMinimalPerf.default 446 430 1.04:1
HeaderMinimalPerf.default 213 204 1.04:1
InputMinimalPerf.default 550 529 1.04:1
PortalMinimalPerf.default 88 85 1.04:1
ProviderMinimalPerf.default 209 203 1.03:1
TableMinimalPerf.default 242 236 1.03:1
TooltipMinimalPerf.default 1311 1272 1.03:1
AttachmentSlotsPerf.default 649 639 1.02:1
CarouselMinimalPerf.default 269 264 1.02:1
DividerMinimalPerf.default 211 207 1.02:1
EmbedMinimalPerf.default 1884 1845 1.02:1
ItemLayoutMinimalPerf.default 704 689 1.02:1
MenuButtonMinimalPerf.default 956 938 1.02:1
RosterPerf.default 1570 1537 1.02:1
SkeletonMinimalPerf.default 206 201 1.02:1
DialogMinimalPerf.default 443 440 1.01:1
HeaderSlotsPerf.default 481 474 1.01:1
MenuMinimalPerf.default 507 504 1.01:1
SegmentMinimalPerf.default 204 201 1.01:1
TreeMinimalPerf.default 483 478 1.01:1
ButtonOverridesMissPerf.default 658 661 1:1
ChatWithPopoverPerf.default 202 202 1:1
DatepickerMinimalPerf.default 3589 3604 1:1
PopupMinimalPerf.default 352 352 1:1
ProviderMergeThemesPerf.default 642 645 1:1
ReactionMinimalPerf.default 219 218 1:1
SplitButtonMinimalPerf.default 2256 2250 1:1
TableManyItemsPerf.default 1095 1096 1:1
CustomToolbarPrototype.default 1469 1464 1:1
ToolbarMinimalPerf.default 540 540 1:1
CheckboxMinimalPerf.default 1125 1142 0.99:1
DropdownMinimalPerf.default 1405 1415 0.99:1
ListCommonPerf.default 386 390 0.99:1
StatusMinimalPerf.default 404 408 0.99:1
IconMinimalPerf.default 387 392 0.99:1
GridMinimalPerf.default 194 197 0.98:1
ListMinimalPerf.default 307 314 0.98:1
ListNestedPerf.default 320 328 0.98:1
BoxMinimalPerf.default 194 201 0.97:1
FlexMinimalPerf.default 149 154 0.97:1
LayoutMinimalPerf.default 199 206 0.97:1
SliderMinimalPerf.default 742 766 0.97:1
VideoMinimalPerf.default 445 459 0.97:1
TextMinimalPerf.default 193 202 0.96:1
DropdownManyItemsPerf.default 372 391 0.95:1
AccordionMinimalPerf.default 82 87 0.94:1
LoaderMinimalPerf.default 180 193 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

fabricteam
fabricteam reviewed Aug 14, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 654 637 5000
Breadcrumb mount 1696 1670 1000
Checkbox mount 1727 1761 5000
CheckboxBase mount 1508 1570 5000
ChoiceGroup mount 2981 3007 5000
ComboBox mount 681 710 1000
CommandBar mount 6664 6660 1000
ContextualMenu mount 13027 12983 1000
DefaultButton mount 804 806 5000
DetailsRow mount 2244 2315 5000
DetailsRowFast mount 2218 2253 5000
DetailsRowNoStyles mount 2055 2086 5000
Dialog mount 2708 2877 1000
DocumentCardTitle mount 231 237 1000
Dropdown mount 2017 2057 5000
FocusTrapZone mount 1162 1144 5000
FocusZone mount 1106 1111 5000
GroupedList mount 42583 42749 2
GroupedList virtual-rerender 20491 20624 2
GroupedList virtual-rerender-with-unmount 52094 52647 2
GroupedListV2 mount 216 230 2
GroupedListV2 virtual-rerender 209 218 2
GroupedListV2 virtual-rerender-with-unmount 234 227 2
IconButton mount 1150 1139 5000
Label mount 355 332 5000
Layer mount 2768 2760 5000
Link mount 397 391 5000
MenuButton mount 1023 1008 5000
MessageBar mount 21148 21223 5000
Nav mount 2076 2088 1000
OverflowSet mount 814 795 5000
Panel mount 1883 1900 1000
Persona mount 743 752 1000
Pivot mount 938 912 1000
PrimaryButton mount 940 960 5000
Rating mount 4673 4801 5000
SearchBox mount 911 927 5000
Shimmer mount 1962 1888 5000
Slider mount 1357 1376 5000
SpinButton mount 2996 3028 5000
Spinner mount 393 396 5000
SplitButton mount 1911 1921 5000
Stack mount 413 428 5000
StackWithIntrinsicChildren mount 886 899 5000
StackWithTextChildren mount 2774 2735 5000
SwatchColorPicker mount 6393 6462 5000
TagPicker mount 1407 1477 5000
Text mount 398 390 5000
TextField mount 955 958 5000
ThemeProvider mount 876 850 5000
ThemeProvider virtual-rerender 594 582 5000
ThemeProvider virtual-rerender-with-unmount 1342 1294 5000
Toggle mount 615 613 5000
buttonNative mount 196 193 5000

Hotell
Hotell reviewed Aug 15, 2024
View reviewed changes
Hotell
Hotell approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@radium-v radium-v force-pushed the users/johnkreitlow/remove-web-types branch from cc490f1 to 8daf356 Compare August 15, 2024 15:35
@radium-v radium-v force-pushed the users/johnkreitlow/remove-web-types branch from 8daf356 to 432fb34 Compare August 15, 2024 18:30
@radium-v radium-v merged commit 8492a7e into microsoft:master Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@davatron5000 davatron5000 davatron5000 approved these changes

@Hotell Hotell Hotell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radium-v @fabricteam @davatron5000 @Hotell