Skip to content

Carousel: Autoplay#32154

Merged
Mitch-At-Work merged 13 commits intomicrosoft:masterfrom
Mitch-At-Work:user/mifraser/carousel-auto-play
Aug 2, 2024
Merged

Carousel: Autoplay#32154
Mitch-At-Work merged 13 commits intomicrosoft:masterfrom
Mitch-At-Work:user/mifraser/carousel-auto-play

Conversation

@Mitch-At-Work
Copy link
Contributor

@Mitch-At-Work Mitch-At-Work commented Jul 29, 2024

Previous Behavior

No autoplay present

New Behavior

Autoplay enabled (only via adding AutoplayButton to enable)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 29, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 29, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 29, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 29, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 95 90 1.06:1 analysis
AttachmentMinimalPerf.default 78 83 0.94:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 211 190 1.11:1
DropdownManyItemsPerf.default 421 389 1.08:1
ButtonSlotsPerf.default 335 312 1.07:1
HeaderMinimalPerf.default 221 206 1.07:1
ImageMinimalPerf.default 245 229 1.07:1
AnimationMinimalPerf.default 308 293 1.05:1
LoaderMinimalPerf.default 194 184 1.05:1
PortalMinimalPerf.default 92 88 1.05:1
DialogMinimalPerf.default 457 439 1.04:1
ListMinimalPerf.default 322 309 1.04:1
RefMinimalPerf.default 120 115 1.04:1
TreeMinimalPerf.default 501 481 1.04:1
FlexMinimalPerf.default 155 150 1.03:1
LabelMinimalPerf.default 223 217 1.03:1
MenuMinimalPerf.default 525 511 1.03:1
RosterPerf.default 1655 1603 1.03:1
TableManyItemsPerf.default 1135 1104 1.03:1
ChatDuplicateMessagesPerf.default 160 157 1.02:1
CheckboxMinimalPerf.default 1139 1119 1.02:1
DividerMinimalPerf.default 207 202 1.02:1
GridMinimalPerf.default 197 193 1.02:1
TextMinimalPerf.default 200 197 1.02:1
ToolbarMinimalPerf.default 549 537 1.02:1
AvatarMinimalPerf.default 116 115 1.01:1
EmbedMinimalPerf.default 1898 1874 1.01:1
ListNestedPerf.default 337 334 1.01:1
PopupMinimalPerf.default 350 346 1.01:1
SegmentMinimalPerf.default 199 198 1.01:1
SkeletonMinimalPerf.default 203 200 1.01:1
StatusMinimalPerf.default 423 418 1.01:1
TreeWith60ListItems.default 91 90 1.01:1
ChatWithPopoverPerf.default 199 199 1:1
DropdownMinimalPerf.default 1446 1450 1:1
ProviderMergeThemesPerf.default 644 645 1:1
TableMinimalPerf.default 238 239 1:1
CustomToolbarPrototype.default 1475 1473 1:1
TooltipMinimalPerf.default 1315 1320 1:1
VideoMinimalPerf.default 434 433 1:1
CardMinimalPerf.default 309 312 0.99:1
FormMinimalPerf.default 226 228 0.99:1
ItemLayoutMinimalPerf.default 691 698 0.99:1
ProviderMinimalPerf.default 205 207 0.99:1
ReactionMinimalPerf.default 210 212 0.99:1
SliderMinimalPerf.default 735 739 0.99:1
DatepickerMinimalPerf.default 3502 3585 0.98:1
ListCommonPerf.default 387 396 0.98:1
MenuButtonMinimalPerf.default 959 976 0.98:1
SplitButtonMinimalPerf.default 2295 2332 0.98:1
ButtonOverridesMissPerf.default 643 660 0.97:1
HeaderSlotsPerf.default 447 459 0.97:1
LayoutMinimalPerf.default 198 205 0.97:1
ListWith60ListItems.default 360 370 0.97:1
CarouselMinimalPerf.default 253 264 0.96:1
InputMinimalPerf.default 538 558 0.96:1
RadioGroupMinimalPerf.default 259 269 0.96:1
AttachmentSlotsPerf.default 618 651 0.95:1
ChatMinimalPerf.default 434 456 0.95:1
IconMinimalPerf.default 398 419 0.95:1
TextAreaMinimalPerf.default 295 312 0.95:1
AccordionMinimalPerf.default 86 92 0.93:1
AlertMinimalPerf.default 158 169 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 29, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 671 686 5000
Button mount 334 307 5000
Field mount 1144 1193 5000
FluentProvider mount 747 749 5000
FluentProviderWithTheme mount 87 95 10
FluentProviderWithTheme virtual-rerender 37 39 10
FluentProviderWithTheme virtual-rerender-with-unmount 85 76 10
MakeStyles mount 963 965 50000
Persona mount 1909 1726 5000
SpinButton mount 1476 1465 5000
SwatchPicker mount 1760 1682 5000

@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/carousel-auto-play branch from 4257722 to d84b872 Compare July 29, 2024 22:43
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 29, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 607 612 5000
Breadcrumb mount 1666 1665 1000
Checkbox mount 1667 1740 5000
CheckboxBase mount 1495 1477 5000
ChoiceGroup mount 2915 2935 5000
ComboBox mount 674 674 1000
CommandBar mount 6545 6570 1000
ContextualMenu mount 11717 12420 1000
DefaultButton mount 807 795 5000
DetailsRow mount 2198 2204 5000
DetailsRowFast mount 2231 2228 5000
DetailsRowNoStyles mount 1960 2014 5000
Dialog mount 2857 2680 1000
DocumentCardTitle mount 227 233 1000
Dropdown mount 2011 2004 5000
FocusTrapZone mount 1172 1162 5000
FocusZone mount 1084 1076 5000
GroupedList mount 37364 41991 2
GroupedList virtual-rerender 20106 20134 2
GroupedList virtual-rerender-with-unmount 51462 51569 2
GroupedListV2 mount 230 222 2
GroupedListV2 virtual-rerender 204 224 2
GroupedListV2 virtual-rerender-with-unmount 226 243 2
IconButton mount 1108 1122 5000
Label mount 334 343 5000
Layer mount 2749 2731 5000
Link mount 384 393 5000
MenuButton mount 963 981 5000
MessageBar mount 21380 21341 5000
Nav mount 2020 2026 1000
OverflowSet mount 786 781 5000
Panel mount 1836 1813 1000
Persona mount 722 756 1000
Pivot mount 890 884 1000
PrimaryButton mount 925 911 5000
Rating mount 4672 4692 5000
SearchBox mount 916 939 5000
Shimmer mount 1800 1893 5000
Slider mount 1328 1317 5000
SpinButton mount 2957 2948 5000
Spinner mount 392 403 5000
SplitButton mount 1862 1863 5000
Stack mount 419 418 5000
StackWithIntrinsicChildren mount 856 864 5000
StackWithTextChildren mount 2796 2766 5000
SwatchColorPicker mount 6387 6315 5000
TagPicker mount 1463 1452 5000
Text mount 400 388 5000
TextField mount 939 928 5000
ThemeProvider mount 871 852 5000
ThemeProvider virtual-rerender 592 590 5000
ThemeProvider virtual-rerender-with-unmount 1299 1304 5000
Toggle mount 624 613 5000
buttonNative mount 193 196 5000

@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/carousel-auto-play branch 2 times, most recently from 44374a8 to 870ccb4 Compare July 31, 2024 16:23
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review July 31, 2024 17:07
@Mitch-At-Work Mitch-At-Work requested review from a team as code owners July 31, 2024 17:07
mltejera
mltejera reviewed Jul 31, 2024
View reviewed changes
Hotell
Hotell reviewed Aug 1, 2024
View reviewed changes
@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/carousel-auto-play branch from 4352889 to 5017a26 Compare August 1, 2024 17:34
@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/carousel-auto-play branch from 5017a26 to 70b0970 Compare August 1, 2024 18:36
@Mitch-At-Work Mitch-At-Work merged commit 759ba6f into microsoft:master Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell left review comments

@fabricteam fabricteam fabricteam left review comments

@layershifter layershifter layershifter left review comments

@mltejera mltejera mltejera approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mitch-At-Work @fabricteam @Hotell @layershifter @mltejera @tudorpopams