feat(motion): add Collapse motion component#31982
Merged
pixel-perfectionist merged 6 commits intomicrosoft:masterfrom Jul 15, 2024
Merged
feat(motion): add Collapse motion component#31982pixel-perfectionist merged 6 commits intomicrosoft:masterfrom
pixel-perfectionist merged 6 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 623 | 612 | 5000 | |
| Button | mount | 304 | 311 | 5000 | |
| Field | mount | 1145 | 1103 | 5000 | |
| FluentProvider | mount | 706 | 710 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 100 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 33 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 82 | 10 | |
| MakeStyles | mount | 878 | 844 | 50000 | |
| Persona | mount | 1810 | 1715 | 5000 | |
| SpinButton | mount | 1392 | 1392 | 5000 | |
| SwatchPicker | mount | 1648 | 1652 | 5000 |
fabricteam
reviewed
Jul 11, 2024
change/@fluentui-react-components-f30ee0ab-4e5d-4a02-8d35-2446318f4b25.json
Outdated
Show resolved
Hide resolved
- Implemented Collapse component in React Motion Library. - Added unit tests for Collapse component. - Created stories for different scenarios including custom, default, exaggerated, override, and snappy collapses. - Updated package.json to include new dependencies and scripts. - Enhanced index and utility files to support new component. - Documented usage and configuration in Custom.stories.md and Description.md.
7d60b2d to
efe8bef
Compare
da4132a to
8fef16e
Compare
layershifter
approved these changes
Jul 15, 2024
- Implemented Collapse component in React Motion Library. - Added unit tests for Collapse component. - Created stories for different scenarios including custom, default, exaggerated, override, and snappy collapses. - Updated package.json to include new dependencies and scripts. - Enhanced index and utility files to support new component. - Documented usage and configuration in Custom.stories.md and Description.md.
0b6119d to
f7a0908
Compare
e31a28f to
f3dbbbc
Compare
…tui into feat/collapse-component
f3dbbbc to
c469616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31982.
Collapsecomponent inreact-motion-components-previewCollapsecomponentNew Behavior
PR adds Collapse motion component:
The
Collapsecomponent manages content presence, using a height expand/collapse motion.