Skip to content

Adding .mcworld and .mctemplate filetype icons, updated FabricCDN url.#30422

Merged
tomi-msft merged 2 commits intomicrosoft:masterfrom
bigbadcapers:caperez/mcworld-filetype-update
Jan 30, 2024
Merged

Adding .mcworld and .mctemplate filetype icons, updated FabricCDN url.#30422
tomi-msft merged 2 commits intomicrosoft:masterfrom
bigbadcapers:caperez/mcworld-filetype-update

Conversation

@bigbadcapers
Copy link
Contributor

@bigbadcapers bigbadcapers commented Jan 29, 2024

  • yarn change
  • yarn lage update to style-utilities (new CDN url location)
  • tested within @fluentui/react-experiments

@bigbadcapers bigbadcapers requested review from a team, Jahnp and dzearing as code owners January 29, 2024 21:08
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 29, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a047db6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@bigbadcapers bigbadcapers marked this pull request as draft January 29, 2024 21:24
@fabricteam
Copy link
Collaborator

fabricteam commented Jan 29, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 29, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
ActivityItem		 0 B
0 B		 68.833 kB
22.613 kB		 🆕 New entry
react
Announced		 0 B
0 B		 36.473 kB
12.628 kB		 🆕 New entry
react
Autofill		 0 B
0 B		 15.365 kB
4.743 kB		 🆕 New entry
react
Breadcrumb		 0 B
0 B		 196.061 kB
58.75 kB		 🆕 New entry
react
Button		 0 B
0 B		 190.138 kB
55.024 kB		 🆕 New entry
react
ButtonGrid		 0 B
0 B		 175.896 kB
53.242 kB		 🆕 New entry
react
Calendar		 0 B
0 B		 118.756 kB
36.101 kB		 🆕 New entry
react
Callout		 0 B
0 B		 80.844 kB
26.56 kB		 🆕 New entry
react
Check		 0 B
0 B		 51.062 kB
17.152 kB		 🆕 New entry
react
Checkbox		 0 B
0 B		 57.791 kB
19.17 kB		 🆕 New entry
react
ChoiceGroup		 0 B
0 B		 63.339 kB
20.824 kB		 🆕 New entry
react
ChoiceGroupOption		 0 B
0 B		 56.601 kB
18.695 kB		 🆕 New entry
react
Coachmark		 0 B
0 B		 89.633 kB
28.377 kB		 🆕 New entry
react
Color		 0 B
0 B		 7.737 kB
3.106 kB		 🆕 New entry
react
ColorPicker		 0 B
0 B		 129.962 kB
40.577 kB		 🆕 New entry
react
ComboBox		 0 B
0 B		 245.333 kB
70.505 kB		 🆕 New entry
react
CommandBar		 0 B
0 B		 197.373 kB
58.465 kB		 🆕 New entry
react
ContextualMenu		 0 B
0 B		 150.945 kB
46.975 kB		 🆕 New entry
react
DatePicker		 0 B
0 B		 180.181 kB
54.902 kB		 🆕 New entry
react
DateTimeUtilities		 0 B
0 B		 5.244 kB
1.849 kB		 🆕 New entry
react
DetailsList		 0 B
0 B		 225.886 kB
64.647 kB		 🆕 New entry
react
Dialog		 0 B
0 B		 205.272 kB
61.429 kB		 🆕 New entry
react
Divider		 0 B
0 B		 17.63 kB
6.234 kB		 🆕 New entry
react
DocumentCard		 0 B
0 B		 211.058 kB
62.788 kB		 🆕 New entry
react
DragDrop		 0 B
0 B		 8.343 kB
2.724 kB		 🆕 New entry
react
DraggableZone		 0 B
0 B		 33.345 kB
11.166 kB		 🆕 New entry
react
Dropdown		 0 B
0 B		 227.71 kB
66.862 kB		 🆕 New entry
react
ExtendedPicker		 0 B
0 B		 94.987 kB
27.297 kB		 🆕 New entry
react
Fabric		 0 B
0 B		 39.75 kB
13.688 kB		 🆕 New entry
react
Facepile		 0 B
0 B		 205.97 kB
61.664 kB		 🆕 New entry
react
FloatingPicker		 0 B
0 B		 236.211 kB
67.362 kB		 🆕 New entry
react
FocusTrapZone		 0 B
0 B		 15.831 kB
5.54 kB		 🆕 New entry
react
FocusZone		 0 B
0 B		 53.259 kB
16.869 kB		 🆕 New entry
react
Grid		 0 B
0 B		 175.896 kB
53.242 kB		 🆕 New entry
react
GroupedList		 0 B
0 B		 131.636 kB
39.657 kB		 🆕 New entry
react
GroupedListV2		 0 B
0 B		 119.324 kB
36.822 kB		 🆕 New entry
react
HoverCard		 0 B
0 B		 93.713 kB
29.775 kB		 🆕 New entry
react
Icon		 0 B
0 B		 49.74 kB
16.603 kB		 🆕 New entry
react
Icons		 0 B
0 B		 65.829 kB
24.212 kB		 🆕 New entry
react
Image		 0 B
0 B		 44.79 kB
15.024 kB		 🆕 New entry
react
Keytip		 0 B
0 B		 78.572 kB
25.817 kB		 🆕 New entry
react
KeytipData		 0 B
0 B		 13.585 kB
4.418 kB		 🆕 New entry
react
KeytipLayer		 0 B
0 B		 100.406 kB
31.12 kB		 🆕 New entry
react
Keytips		 0 B
0 B		 103.159 kB
32.062 kB		 🆕 New entry
react
Label		 0 B
0 B		 36.347 kB
12.639 kB		 🆕 New entry
react
Layer		 0 B
0 B		 45.683 kB
15.585 kB		 🆕 New entry
react
Link		 0 B
0 B		 37.673 kB
12.993 kB		 🆕 New entry
react
List		 0 B
0 B		 38.136 kB
12.004 kB		 🆕 New entry
react
MarqueeSelection		 0 B
0 B		 72.119 kB
21.676 kB		 🆕 New entry
react
MessageBar		 0 B
0 B		 184.685 kB
55.518 kB		 🆕 New entry
react
Modal		 0 B
0 B		 90.409 kB
29.213 kB		 🆕 New entry
react
Nav		 0 B
0 B		 183.42 kB
55.087 kB		 🆕 New entry
react
OverflowSet		 0 B
0 B		 31.044 kB
10.593 kB		 🆕 New entry
react
Overlay		 0 B
0 B		 38.784 kB
13.401 kB		 🆕 New entry
react
Panel		 0 B
0 B		 194.924 kB
58.335 kB		 🆕 New entry
react
Persona		 0 B
0 B		 111.683 kB
35.57 kB		 🆕 New entry
react
PersonaCoin		 0 B
0 B		 111.683 kB
35.57 kB		 🆕 New entry
react
PersonaPresence		 0 B
0 B		 55.928 kB
18.715 kB		 🆕 New entry
react
Pickers		 0 B
0 B		 287.581 kB
80.6 kB		 🆕 New entry
react
Pivot		 0 B
0 B		 184.23 kB
55.818 kB		 🆕 New entry
react
Popup		 0 B
0 B		 12.032 kB
4.114 kB		 🆕 New entry
react
Positioning		 0 B
0 B		 21.821 kB
7.334 kB		 🆕 New entry
react
PositioningContainer		 0 B
0 B		 70.754 kB
22.84 kB		 🆕 New entry
react
ProgressIndicator		 0 B
0 B		 37.498 kB
12.906 kB		 🆕 New entry
react
Rating		 0 B
0 B		 78.989 kB
25.18 kB		 🆕 New entry
react
ResizeGroup		 0 B
0 B		 13.286 kB
4.365 kB		 🆕 New entry
react
ResponsiveMode		 0 B
0 B		 8.078 kB
2.95 kB		 🆕 New entry
react
ScrollablePane		 0 B
0 B		 53.538 kB
17.113 kB		 🆕 New entry
react
SearchBox		 0 B
0 B		 182.96 kB
55.094 kB		 🆕 New entry
react
SelectableOption		 0 B
0 B		 724 B
413 B		 🆕 New entry
react
SelectedItemsList		 0 B
0 B		 226.637 kB
66.316 kB		 🆕 New entry
react
Selection		 0 B
0 B		 41.202 kB
11.839 kB		 🆕 New entry
react
Separator		 0 B
0 B		 33.397 kB
11.529 kB		 🆕 New entry
react
Shimmer		 0 B
0 B		 47.265 kB
15.632 kB		 🆕 New entry
react
ShimmeredDetailsList		 0 B
0 B		 236.654 kB
67.42 kB		 🆕 New entry
react
Slider		 0 B
0 B		 55.575 kB
18.574 kB		 🆕 New entry
react
SpinButton		 0 B
0 B		 186.639 kB
56.2 kB		 🆕 New entry
react
Spinner		 0 B
0 B		 39.691 kB
13.815 kB		 🆕 New entry
react
Stack		 0 B
0 B		 40.761 kB
13.931 kB		 🆕 New entry
react
Sticky		 0 B
0 B		 32.064 kB
10.324 kB		 🆕 New entry
react
Styling		 0 B
0 B		 44.812 kB
14.688 kB		 🆕 New entry
react
SwatchColorPicker		 0 B
0 B		 186.144 kB
56.719 kB		 🆕 New entry
react
TeachingBubble		 0 B
0 B		 199.982 kB
59.339 kB		 🆕 New entry
react
Text		 0 B
0 B		 35.931 kB
12.486 kB		 🆕 New entry
react
TextField		 0 B
0 B		 78.587 kB
24.642 kB		 🆕 New entry
react
Theme		 0 B
0 B		 42.456 kB
13.773 kB		 🆕 New entry
react
ThemeGenerator		 0 B
0 B		 12.34 kB
4.106 kB		 🆕 New entry
react
TimePicker		 0 B
0 B		 235.175 kB
68.285 kB		 🆕 New entry
react
Toggle		 0 B
0 B		 44.17 kB
15.346 kB		 🆕 New entry
react
Tooltip		 0 B
0 B		 84.203 kB
27.268 kB		 🆕 New entry
react
Utilities		 0 B
0 B		 71.851 kB
21.843 kB		 🆕 New entry
react
Viewport		 0 B
0 B		 22.945 kB
7.292 kB		 🆕 New entry
react
WeeklyDayPicker		 0 B
0 B		 98.762 kB
30.828 kB		 🆕 New entry
react
WindowProvider		 0 B
0 B		 1.059 kB
541 B		 🆕 New entry

🤖 This report was generated against 491d0cb952b14057711ff36348da50db92eaf78d

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 29, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 638 642 5000
Breadcrumb mount 1705 1666 1000
Checkbox mount 1684 1713 5000
CheckboxBase mount 1481 1458 5000
ChoiceGroup mount 2991 2983 5000
ComboBox mount 657 661 1000
CommandBar mount 6273 6233 1000
ContextualMenu mount 12763 12599 1000
DefaultButton mount 769 769 5000
DetailsRow mount 2229 2191 5000
DetailsRowFast mount 2203 2181 5000
DetailsRowNoStyles mount 2039 2083 5000
Dialog mount 2705 2699 1000
DocumentCardTitle mount 231 223 1000
Dropdown mount 2027 2011 5000
FocusTrapZone mount 1154 1133 5000
FocusZone mount 1104 1070 5000
GroupedList mount 42165 47557 2
GroupedList virtual-rerender 20133 23067 2
GroupedList virtual-rerender-with-unmount 51038 50740 2
GroupedListV2 mount 226 222 2
GroupedListV2 virtual-rerender 217 216 2
GroupedListV2 virtual-rerender-with-unmount 223 230 2
IconButton mount 1110 1096 5000
Label mount 337 336 5000
Layer mount 2729 2778 5000
Link mount 396 396 5000
MenuButton mount 969 1004 5000
MessageBar mount 21306 21338 5000
Nav mount 1982 1977 1000
OverflowSet mount 806 786 5000
Panel mount 2113 1766 1000
Persona mount 722 810 1000
Pivot mount 881 871 1000
PrimaryButton mount 851 864 5000
Rating mount 4639 4604 5000
SearchBox mount 955 932 5000
Shimmer mount 1924 1918 5000
Slider mount 1327 1345 5000
SpinButton mount 2893 2845 5000
Spinner mount 391 394 5000
SplitButton mount 1893 1899 5000
Stack mount 407 417 5000
StackWithIntrinsicChildren mount 853 851 5000
StackWithTextChildren mount 2664 2660 5000
SwatchColorPicker mount 6217 6222 5000
TagPicker mount 1554 1426 5000
Text mount 359 381 5000
TextField mount 947 968 5000
ThemeProvider mount 831 836 5000
ThemeProvider virtual-rerender 595 618 5000
ThemeProvider virtual-rerender-with-unmount 1299 1261 5000
Toggle mount 634 616 5000
buttonNative mount 190 194 5000

@size-auditor
Copy link

size-auditor bot commented Jan 29, 2024

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4ea2ac442b26360c3e0e86a0225ac4570c89f636 (build)

@tomi-msft
Copy link
Contributor

tomi-msft commented Jan 29, 2024

Thanks for adding this. Let me know when you're ready to move from a draft pr and I can approve it!

@bigbadcapers bigbadcapers marked this pull request as ready for review January 29, 2024 23:29
@bigbadcapers
Copy link
Contributor Author

bigbadcapers commented Jan 30, 2024 via email •
edited by microsoft-github-policy-service bot
Loading

@tomi-msft tomi-msft merged commit 7f29fb6 into microsoft:master Jan 30, 2024
@bigbadcapers bigbadcapers deleted the caperez/mcworld-filetype-update branch October 28, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzearing dzearing Awaiting requested review from dzearing

@Jahnp Jahnp Awaiting requested review from Jahnp Jahnp is a code owner

1 more reviewer

@tomi-msft tomi-msft tomi-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigbadcapers @fabricteam @tomi-msft