Skip to content

chore: bump keyborg to 2.1.0#29520

Merged
ling1726 merged 2 commits intomicrosoft:masterfrom
ling1726:chore/bump-keyborg-101220231
Oct 16, 2023
Merged

chore: bump keyborg to 2.1.0#29520
ling1726 merged 2 commits intomicrosoft:masterfrom
ling1726:chore/bump-keyborg-101220231

Conversation

@ling1726
Copy link
Contributor

@ling1726 ling1726 commented Oct 13, 2023

Fixes #27807

@ling1726 ling1726 marked this pull request as ready for review October 13, 2023 07:19
@ling1726 ling1726 requested review from a team as code owners October 13, 2023 07:19
@ling1726 ling1726 force-pushed the chore/bump-keyborg-101220231 branch from fb9fa10 to 92a907e Compare October 13, 2023 07:26
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2023 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)		 92.961 kB
28.372 kB		 93.164 kB
28.391 kB		 203 B
19 B
react-card
Card - All		 92.829 kB
26.915 kB		 93.032 kB
26.934 kB		 203 B
19 B
react-card
Card		 87.653 kB
25.399 kB		 87.856 kB
25.435 kB		 203 B
36 B
react-checkbox
Checkbox		 37.235 kB
12.278 kB		 37.438 kB
12.302 kB		 203 B
24 B
react-combobox
Combobox (including child components)		 91.564 kB
29.879 kB		 91.767 kB
29.912 kB		 203 B
33 B
react-combobox
Dropdown (including child components)		 90.004 kB
29.537 kB		 90.207 kB
29.572 kB		 203 B
35 B
react-components
react-components: Button, FluentProvider & webLightTheme		 69.863 kB
20.148 kB		 70.066 kB
20.174 kB		 203 B
26 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.62 kB
59.701 kB		 207.823 kB
59.72 kB		 203 B
19 B
react-components
react-components: FluentProvider & webLightTheme		 42.142 kB
13.97 kB		 42.345 kB
13.999 kB		 203 B
29 B
react-datepicker-compat
DatePicker Compat		 211.96 kB
59.117 kB		 212.163 kB
59.148 kB		 203 B
31 B
react-dialog
Dialog (including children components)		 89.578 kB
26.737 kB		 89.781 kB
26.759 kB		 203 B
22 B
react-infobutton
InfoButton		 130.378 kB
41.093 kB		 130.581 kB
41.112 kB		 203 B
19 B
react-infobutton
InfoLabel		 134.068 kB
42.26 kB		 134.271 kB
42.282 kB		 203 B
22 B
react-menu
Menu (including children components)		 140.201 kB
43.339 kB		 140.404 kB
43.358 kB		 203 B
19 B
react-menu
Menu (including selectable components)		 142.887 kB
43.852 kB		 143.09 kB
43.871 kB		 203 B
19 B
react-popover
Popover		 119.11 kB
37.616 kB		 119.313 kB
37.636 kB		 203 B
20 B
react-portal
Portal		 12.255 kB
4.504 kB		 12.458 kB
4.537 kB		 203 B
33 B
react-portal-compat
PortalCompatProvider		 6.503 kB
2.22 kB		 6.706 kB
2.25 kB		 203 B
30 B
react-provider
FluentProvider		 22.687 kB
8.399 kB		 22.89 kB
8.428 kB		 203 B
29 B
react-radio
Radio		 30.996 kB
10.223 kB		 31.199 kB
10.247 kB		 203 B
24 B
react-slider
Slider		 38.146 kB
12.57 kB		 38.349 kB
12.595 kB		 203 B
25 B
react-switch
Switch		 33.455 kB
10.846 kB		 33.658 kB
10.875 kB		 203 B
29 B
react-table
DataGrid		 156.97 kB
43.826 kB		 157.173 kB
43.849 kB		 203 B
23 B
react-table
Table (Primitives only)		 43.797 kB
13.732 kB		 44 kB
13.758 kB		 203 B
26 B
react-table
Table as DataGrid		 130.265 kB
35.168 kB		 130.468 kB
35.189 kB		 203 B
21 B
react-table
Table (Selection only)		 75.633 kB
20.448 kB		 75.836 kB
20.475 kB		 203 B
27 B
react-table
Table (Sort only)		 74.24 kB
20.048 kB		 74.443 kB
20.075 kB		 203 B
27 B
react-tags
TagGroup		 73.857 kB
22.067 kB		 74.06 kB
22.091 kB		 203 B
24 B
react-toast
Toast (including Toaster)		 92.478 kB
27.738 kB		 92.681 kB
27.76 kB		 203 B
22 B
react-tooltip
Tooltip		 52.322 kB
18.42 kB		 52.525 kB
18.46 kB		 203 B
40 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.162 kB
1.735 kB
react-alert
Alert		 84.287 kB
23.469 kB
react-avatar
Avatar		 50.461 kB
15.901 kB
react-avatar
AvatarGroup		 19.992 kB
7.871 kB
react-avatar
AvatarGroupItem		 65.117 kB
20.238 kB
react-badge
Badge		 27.197 kB
8.779 kB
react-badge
CounterBadge		 28.098 kB
9.074 kB
react-badge
PresenceBadge		 25.603 kB
9.283 kB
react-button
Button		 40.007 kB
11.277 kB
react-button
CompoundButton		 47.363 kB
12.768 kB
react-button
MenuButton		 44.781 kB
12.649 kB
react-button
SplitButton		 52.795 kB
14.236 kB
react-button
ToggleButton		 57.054 kB
13.176 kB
react-card
CardFooter		 13.423 kB
5.481 kB
react-card
CardHeader		 15.666 kB
6.235 kB
react-card
CardPreview		 14.374 kB
5.854 kB
react-divider
Divider		 21.112 kB
7.812 kB
react-field
Field		 22.721 kB
8.611 kB
react-image
Image		 16.096 kB
6.317 kB
react-input
Input		 27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma		 1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime		 4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime		 4.734 kB
1.983 kB
react-label
Label		 14.435 kB
5.83 kB
react-link
Link		 17.328 kB
6.947 kB
react-message-bar
MessageBar (all components)		 25.54 kB
9.102 kB
react-overflow
hooks only		 12.419 kB
4.687 kB
react-persona
Persona		 57.352 kB
17.774 kB
react-positioning
usePositioning		 25.305 kB
9.162 kB
react-progress
ProgressBar		 17.725 kB
6.965 kB
react-radio
RadioGroup		 15.631 kB
6.33 kB
react-select
Select		 28.968 kB
10.269 kB
react-spinbutton
SpinButton		 37.133 kB
11.856 kB
react-spinner
Spinner		 23.688 kB
8.536 kB
react-tags
InteractionTag		 15.618 kB
6.152 kB
react-tags
Tag		 30.341 kB
9.505 kB
react-text
Text - Default		 17.065 kB
6.645 kB
react-text
Text - Wrappers		 20.237 kB
6.965 kB
react-textarea
Textarea		 31.306 kB
10.549 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.611 kB
7.295 kB
react-theme
Teams: Light theme		 19.282 kB
5.486 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against b03a47260f977d472f34e3402dc89d3e3d56f760

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 72 79 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 639 625 5000
Button mount 320 320 5000
Field mount 1146 1181 5000
FluentProvider mount 702 687 5000
FluentProviderWithTheme mount 76 88 10
FluentProviderWithTheme virtual-rerender 71 68 10
FluentProviderWithTheme virtual-rerender-with-unmount 72 79 10 Possible regression
InfoButton mount 14 13 5000
MakeStyles mount 857 864 50000
Persona mount 1744 1687 5000
SpinButton mount 1334 1446 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AvatarMinimalPerf.default 106 103 1.03:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 219 184 1.19:1
ChatDuplicateMessagesPerf.default 155 139 1.12:1
ImageMinimalPerf.default 240 217 1.11:1
StatusMinimalPerf.default 413 391 1.06:1
ButtonSlotsPerf.default 327 311 1.05:1
FormMinimalPerf.default 232 222 1.05:1
InputMinimalPerf.default 558 533 1.05:1
SegmentMinimalPerf.default 195 185 1.05:1
ButtonOverridesMissPerf.default 646 620 1.04:1
ListMinimalPerf.default 308 297 1.04:1
MenuButtonMinimalPerf.default 973 934 1.04:1
CardMinimalPerf.default 312 303 1.03:1
CarouselMinimalPerf.default 268 260 1.03:1
HeaderSlotsPerf.default 466 454 1.03:1
ListCommonPerf.default 395 384 1.03:1
LoaderMinimalPerf.default 189 184 1.03:1
ReactionMinimalPerf.default 226 220 1.03:1
SliderMinimalPerf.default 748 725 1.03:1
TableMinimalPerf.default 239 233 1.03:1
AttachmentSlotsPerf.default 639 627 1.02:1
ChatMinimalPerf.default 450 442 1.02:1
EmbedMinimalPerf.default 1900 1868 1.02:1
PortalMinimalPerf.default 87 85 1.02:1
ProviderMinimalPerf.default 206 201 1.02:1
RadioGroupMinimalPerf.default 264 259 1.02:1
SplitButtonMinimalPerf.default 2263 2225 1.02:1
TextMinimalPerf.default 188 185 1.02:1
AnimationMinimalPerf.default 298 295 1.01:1
CheckboxMinimalPerf.default 1161 1153 1.01:1
DatepickerMinimalPerf.default 3534 3515 1.01:1
DropdownManyItemsPerf.default 395 390 1.01:1
ProviderMergeThemesPerf.default 648 643 1.01:1
CustomToolbarPrototype.default 1478 1459 1.01:1
LabelMinimalPerf.default 220 219 1:1
LayoutMinimalPerf.default 203 202 1:1
PopupMinimalPerf.default 348 349 1:1
RefMinimalPerf.default 109 109 1:1
IconMinimalPerf.default 397 397 1:1
TextAreaMinimalPerf.default 283 282 1:1
ToolbarMinimalPerf.default 526 525 1:1
TreeMinimalPerf.default 477 477 1:1
DividerMinimalPerf.default 197 198 0.99:1
ItemLayoutMinimalPerf.default 705 710 0.99:1
ListWith60ListItems.default 372 375 0.99:1
TableManyItemsPerf.default 1111 1118 0.99:1
TooltipMinimalPerf.default 1287 1297 0.99:1
ButtonMinimalPerf.default 86 88 0.98:1
DropdownMinimalPerf.default 1415 1437 0.98:1
FlexMinimalPerf.default 147 150 0.98:1
GridMinimalPerf.default 188 192 0.98:1
ListNestedPerf.default 318 324 0.98:1
MenuMinimalPerf.default 487 499 0.98:1
RosterPerf.default 1540 1567 0.98:1
AccordionMinimalPerf.default 83 86 0.97:1
HeaderMinimalPerf.default 203 209 0.97:1
VideoMinimalPerf.default 428 441 0.97:1
AlertMinimalPerf.default 154 161 0.96:1
AttachmentMinimalPerf.default 77 80 0.96:1
DialogMinimalPerf.default 439 455 0.96:1
SkeletonMinimalPerf.default 180 187 0.96:1
ChatWithPopoverPerf.default 188 197 0.95:1
TreeWith60ListItems.default 77 84 0.92:1

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 92a907e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
pedantic-germain-ypm8zk Issue #27807

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 641 626 5000
Breadcrumb mount 1744 1735 1000
Checkbox mount 1739 1686 5000
CheckboxBase mount 1511 1490 5000
ChoiceGroup mount 3004 2996 5000
ComboBox mount 667 666 1000
CommandBar mount 6376 6343 1000
ContextualMenu mount 13788 13587 1000
DefaultButton mount 770 754 5000
DetailsRow mount 2150 2192 5000
DetailsRowFast mount 2224 2174 5000
DetailsRowNoStyles mount 2029 2036 5000
Dialog mount 2806 2699 1000
DocumentCardTitle mount 227 229 1000
Dropdown mount 2047 2020 5000
FocusTrapZone mount 1153 1143 5000
FocusZone mount 1047 1052 5000
GroupedList mount 41676 41789 2
GroupedList virtual-rerender 20161 19951 2
GroupedList virtual-rerender-with-unmount 51010 51127 2
GroupedListV2 mount 232 225 2
GroupedListV2 virtual-rerender 220 208 2
GroupedListV2 virtual-rerender-with-unmount 231 238 2
IconButton mount 1111 1090 5000
Label mount 348 341 5000
Layer mount 2718 2741 5000
Link mount 406 398 5000
MenuButton mount 949 942 5000
MessageBar mount 22084 22020 5000
Nav mount 1995 1974 1000
OverflowSet mount 775 790 5000
Panel mount 1839 1793 1000
Persona mount 753 764 1000
Pivot mount 890 879 1000
PrimaryButton mount 857 873 5000
Rating mount 4688 4704 5000
SearchBox mount 929 941 5000
Shimmer mount 1884 1897 5000
Slider mount 1332 1346 5000
SpinButton mount 2935 2910 5000
Spinner mount 384 402 5000
SplitButton mount 1823 1861 5000
Stack mount 405 419 5000
StackWithIntrinsicChildren mount 866 859 5000
StackWithTextChildren mount 2632 2642 5000
SwatchColorPicker mount 6133 6107 5000
TagPicker mount 1449 1547 5000
Text mount 370 370 5000
TextField mount 948 962 5000
ThemeProvider mount 833 840 5000
ThemeProvider virtual-rerender 575 583 5000
ThemeProvider virtual-rerender-with-unmount 1285 1281 5000
Toggle mount 609 613 5000
buttonNative mount 194 199 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2023

🕵 FluentUIV0 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Oct 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b03a47260f977d472f34e3402dc89d3e3d56f760 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@ling1726 ling1726 merged commit 335cad5 into microsoft:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@layershifter layershifter layershifter approved these changes

Assignees

No one assigned

Labels

Component: Dialog Component: Radio

Projects

None yet

Milestone

October Project Cycle Q4 2023

Development

Successfully merging this pull request may close these issues.

[Bug]: Radio button inside dialog shows focus rectangle, outside it doesn't

4 participants

@ling1726 @fabricteam @TristanWatanabe @layershifter