Add docs for HighCardinalityTagsDetector#6822
Closed
jonatan-ivanov wants to merge 1 commit intomicrometer-metrics:mainfrom
Closed
Add docs for HighCardinalityTagsDetector#6822jonatan-ivanov wants to merge 1 commit intomicrometer-metrics:mainfrom
jonatan-ivanov wants to merge 1 commit intomicrometer-metrics:mainfrom
Conversation
27fd6ba to
1005d3f
Compare
shakuzen
reviewed
Oct 30, 2025
Member
shakuzen
left a comment
There was a problem hiding this comment.
Looks good overall. I left a few comments.
shakuzen
approved these changes
Oct 31, 2025
a9cd6bc to
bf92fb5
Compare
jonatan-ivanov
added a commit
that referenced
this pull request
Oct 31, 2025
jonatan-ivanov
added a commit
that referenced
this pull request
Oct 31, 2025
jonatan-ivanov
added a commit
that referenced
this pull request
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is in draft since this needs to be done for
1.14.x. I made it againstmainsince we added a builder and I wanted to get this reviewed including that part. Once this is reviewed and ready to be merged, I will remove the builder parts, rebase on1.14.xand put the removed parts back during forward merge.