fix: exception when glob pattern contains constructor#144
Merged
jonschlinkert merged 3 commits intomicromatch:masterfrom Jul 15, 2025
Merged
fix: exception when glob pattern contains constructor#144jonschlinkert merged 3 commits intomicromatch:masterfrom
constructor#144jonschlinkert merged 3 commits intomicromatch:masterfrom
Conversation
Contributor
Author
|
Is there any way this can make it in? There is a similar fix in #132, but it is slower. |
|
@jonschlinkert, could you please take a look at this when you have a moment? I spent some time debugging an error with |
ngraef
reviewed
May 22, 2025
Jason3S
commented
May 23, 2025
ngraef
suggested changes
May 23, 2025
Contributor
Author
|
@jonschlinkert Thank you. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Closed
danez
pushed a commit
that referenced
this pull request
Mar 19, 2026
fix: exception when glob pattern contains `constructor`
doowb
added a commit
that referenced
this pull request
Mar 20, 2026
[v2] Backport proto fix to v2 #144
danez
pushed a commit
that referenced
this pull request
Mar 23, 2026
fix: exception when glob pattern contains `constructor`
This was referenced Mar 26, 2026
Closed
Closed
This was referenced Mar 26, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picomatch will throw exceptions when the glob contains any Object instance property names.
Examples:
constructor,__proto__,toStringRelated to issue: streetsidesoftware/cspell#7194