enforce-switch-style: handle type switches#1629
Merged
alexandear merged 1 commit intomgechev:masterfrom Feb 10, 2026
Merged
Conversation
enforce-switch-style to work on type switches
alexandear
approved these changes
Feb 10, 2026
Collaborator
|
@weppos thank you! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for type-switch to the rule
enforce-switch-style.As described in the associated ticket, this is motivated by a bug we found in our codebase where we missed an else clause for a type-switch. And when trying to enforce the rule via golangci-lint, we found that the type-switch was ignored nonetheless.
Further investigation revealed that Revive is currently skipping type-switches.
This is how a failure will be reported:
Closes #1628