change: merge code-style with style categories#1573
Merged
chavacava merged 2 commits intomgechev:masterfrom Nov 9, 2025
Merged
change: merge code-style with style categories#1573chavacava merged 2 commits intomgechev:masterfrom
chavacava merged 2 commits intomgechev:masterfrom
Conversation
ccoVeille
reviewed
Nov 8, 2025
ccoVeille
reviewed
Nov 9, 2025
| FailureCategoryBadPractice FailureCategory = "bad practice" | ||
| // FailureCategoryCodeStyle indicates code style issues. | ||
| // | ||
| // Deprecated: use FailureCategoryStyle instead. |
Contributor
There was a problem hiding this comment.
This would be better in the documentation
Suggested change
| // Deprecated: use FailureCategoryStyle instead. | |
| // Deprecated: use [FailureCategoryStyle] instead. |
Collaborator
Author
There was a problem hiding this comment.
It doesn't matter for consts
pkgsite:
VS Code:
Contributor
There was a problem hiding this comment.
it looks like a bug to me in godoc then. But OK, thanks for checking.
My IDE follows such notation anyway, so I use it everywhere now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose merging the
code-styleandstylelinter categories into one.