fix: rule confusing-naming false positive on multiple blank identifiers#1536
Merged
chavacava merged 4 commits intomgechev:masterfrom Oct 6, 2025
emmanuel-ferdman:master
Merged
fix: rule confusing-naming false positive on multiple blank identifiers#1536chavacava merged 4 commits intomgechev:masterfrom emmanuel-ferdman:master
confusing-naming false positive on multiple blank identifiers#1536chavacava merged 4 commits intomgechev:masterfrom
emmanuel-ferdman:master
Conversation
…iers Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
…iers Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Collaborator
|
Hi @emmanuel-ferdman, thanks for the PR. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
confusing-namingrule was incorrectly reporting false positives when Go structs contained multiple blank identifier (_) fields, which are commonly used for padding and alignment. The rule'scheckStructFieldsfunction was treating all field names equally, including blank identifiers, causing it to flag the second occurrence of_as differing only by capitalization from the first. This fix adds a simple check to skip blank identifiers before performing the capitalization comparison, as blank identifiers are special in Go and explicitly allowed to appear multiple times in the same struct according to the language specification.Example:
Old output:
Fixes #1535.