Skip to content

feat: return Future in DavLockSystem#39

Merged
messense merged 1 commit intomessense:mainfrom
yuntara:feature/async-locksystem
Jan 16, 2025
Merged

feat: return Future in DavLockSystem#39
messense merged 1 commit intomessense:mainfrom
yuntara:feature/async-locksystem

Conversation

@yuntara
Copy link
Copy Markdown
Contributor

@yuntara yuntara commented Jan 15, 2025

No description provided.

@messense
Copy link
Copy Markdown
Owner

Thanks for the PR, could you elaborate on the use case?

@yuntara
Copy link
Copy Markdown
Contributor Author

yuntara commented Jan 16, 2025

Sorry for forgetting the text.
I created this PR because I want to access my DataBase asynchronously using the locking mechanism, but the DavLockSystem trait is synchronous.

However, this would break the existing DavLockSystem interface, so if there is a demand for synchronous access, it might be better to separate it with a feature flag or implement it some other way.

@messense messense merged commit 4f5092c into messense:main Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants