Add protobufs repo as git submodule#882
Merged
danditomaso merged 4 commits intoOct 14, 2025
Merged
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the meshtastic-protobufs repository as a git submodule under packages/protobufs to match how other client apps handle protobuf usage and publishing. This change aligns with the standard approach for managing protobufs dependencies in the Meshtastic ecosystem and supports centralized version control of protobuf definitions.
- Adds meshtastic-protobufs as a git submodule configured to track the main branch
- Updates dependency management to use workspace reference instead of external JSR package
- Includes route configuration updates for map functionality with coordinate parameter validation
Reviewed Changes
Copilot reviewed 66 out of 69 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web/src/routes.tsx | Adds new route with coordinate parameter validation for map functionality |
| packages/protobufs/* | Complete protobuf definitions and build configuration from submodule |
| package.json | Updates dependency to use workspace reference |
| .gitmodules | Configures git submodule for protobufs repository |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/protobufs/deno.json:1
- Version mismatch: This file uses @bufbuild/protobuf@^2.9.0 while packages/protobufs/packages/ts/package.json uses ^2.9.0, but the main package.json uses ^2.8.0. Consider aligning versions across all files.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added protobufs repo as git submodule to match how other client apps handle protobuf usage/publishing, added it to folder under packages/protobufs
Related Issues
Changes Made
Testing Done
Tested locally using Act github action simulator
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)